bugGNU Octave - Bugs: bug #54335, add support for bracketed paste...

 
 

bug #54335: add support for bracketed paste mode in command terminal window

Submitter:  S├ębastien Villemot <svillemot>
Submitted:  Wed 18 Jul 2018 07:31:57 PM UTC
   
 
Category:  GUI Severity:  1 - Wish
Priority:  3 - Low Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 4.4.0 Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 01 Dec 2021 07:01:40 PM UTC, comment #5: 

after 3 years of Ready for Test, assuming this can be closed as Fixed.

Nicholas Jankowski <nrjank>
Group Member
Wed 27 Jan 2021 02:48:22 PM UTC, comment #4: 

I pushed the following changesets so that the GUI terminal now handles bracketed paste mode and to improve handling of multi-line pasted input:

http://hg.savannah.gnu.org/hgweb/octave/rev/3180f830d396
http://hg.savannah.gnu.org/hgweb/octave/rev/036079c9ee12
http://hg.savannah.gnu.org/hgweb/octave/rev/cabb840fc3f6

Marking as ready for test.

John W. Eaton <jwe>
Group administrator
Thu 19 Nov 2020 08:54:49 PM UTC, comment #3: 

I can confirm that with Readline version 8.1, bracketed paste mode is now enabled by default.

Adding 'set enable-bracketed-paste off' to ~/.inputrc turns it off and the warning messages are suppressed again.

It seems there may be some pressure to make a small workaround fix to suppress the warning messages even if we don't have the energy to fully support bracketed paste in the terminal widget for now.

Mike Miller <mtmiller>
Group Member
Wed 18 Jul 2018 08:32:17 PM UTC, comment #2: 

I believe this is the project that our Unix terminal widget is based on:

  https://github.com/lxqt/qtermwidget

Note that the Windows version of this terminal is separate, but made to provide a similar widget interface, at least as far as the Octave command window is concerned.

The current sources of qtermwidget do appear to handle bracketed cut and paste.  However, we have made changes in our copy, so we can't simply update to the latest sources.

And, as Mike said, I'm not sure we want to keep this as the terminal implementation anyway.  I'd prefer to unify the Unix and Windows command window widgets to eliminate the duplication.

John W. Eaton <jwe>
Group administrator
Wed 18 Jul 2018 07:59:16 PM UTC, comment #1: 

I've only read a little about this, but to clarify, I think that readline already supports this feature, therefore Octave already supports bracketed pasting as an input to its command line. The part that is broken here is the qterminal widget used in the GUI command window.

At the very least, I think we can patch our embedded copy of qterminal to simply discard these start and end sequences.

If we want to keep qterminal (not sure that we do), someone could look at updating the widget to actually support bracketed paste mode, or import patches if that has already been done to qterminal by someone else.

Mike Miller <mtmiller>
Group Member
Wed 18 Jul 2018 07:31:57 PM UTC, original submission:  

Activating bracketed paste mode in ~/.inputrc via:

set enable-bracketed-paste on

leads to messages like this in the terminal window:

>> undecodable token: \001b(hex)[?2004l
undecodable token: \001b(hex)[?2004h


For more background, see:

https://cirw.in/blog/bracketed-paste

and also the discussion in bug #49385.

S├ębastien Villemot <svillemot>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by svillemot (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-12-01 nrjank StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2021-01-27 jwe StatusConfirmed Ready For Test
    2020-11-19 mtmiller Carbon-CopyRemoved 80942 -
    2020-11-19 mtmiller Dependencies- bugs #59483 is dependent
    2018-07-18 mtmiller Severity3 - Normal 1 - Wish
        Priority5 - Normal 3 - Low
        Item GroupNone Feature Request
        StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-b921.
    Corresponding source code