bugGNU Octave - Bugs: bug #53902, Reduce whitespace in Editor...

 
 

bug #53902: Reduce whitespace in Editor (undocked)

Submitted by:  Ceral Paquet <octavebugs>
Submitted on:  Mon 14 May 2018 07:16:55 PM UTC  
 
Category:  GUI Severity:  1 - Wish
Priority:  3 - Low Item Group:  Feature Request
Status:  Fixed Assigned to:  Torsten Lilge <ttl>
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 07 Oct 2019 03:29:49 PM UTC, comment #21: 

>> Can this report be closed now?

Yes, I think so.

Pantxo Diribarne <pantxo>
Project Member
Mon 07 Oct 2019 03:27:19 PM UTC, comment #20: 

Can this report be closed now?

Rik <rik5>
Project Administrator
Mon 07 Oct 2019 08:27:27 AM UTC, comment #19: 

I can confirm that with the latest change, the figure (and other) toolbar size is slightly decreased (less that with previous changes) and still responsive.

Pantxo Diribarne <pantxo>
Project Member
Sun 06 Oct 2019 08:32:38 PM UTC, comment #18: 

Changeset http://hg.savannah.gnu.org/hgweb/octave/rev/9e526393d80a fixes the issue with the "non responsive" toolbar buttons when hovered or pushed. The new style sheet, which is now only applied to the tool bar and not to the items therein, is also used for the tool bar used for the figure widgets.

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Fri 04 Oct 2019 03:43:26 PM UTC, comment #17: 

Confirmed on Debian with Gnome. I already have an idea what the problem might be and will have a closer look over the weekend.

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Fri 04 Oct 2019 08:25:24 AM UTC, comment #16: 

I backed out the cset that reduced figure toolbar size because with the new style sheet toggle buttons have the same aspect whether they are activated or not.

I couldn't find a toggle button in the GUI toolbars (only push buttons) so this doesn't seem to be an issue in the GUI.

Note though that there is still a visual difference even for push buttons: on my system (debian stretch with Cinamon desktop), with the standard stylesheet, hovering a button with the mouse  will highlight it (the background color is lighter); with the compact stylesheet, nothing happens. 

Pantxo Diribarne <pantxo>
Project Member
Thu 03 Oct 2019 05:29:54 PM UTC, comment #15: 

I have pushed two more changesets for reducing the space in all dock widgets and for reducing the vertical space required by a menu bar. It seems that the effect on the menu bar depends on the style that is globally used by Octave. On my window manager (GNOME) the menu bar already was quite compact without any additional space.

Can the report be closed?

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Mon 30 Sep 2019 10:58:38 AM UTC, comment #14: 

I pushed a similar cset to make the figure toolbar size consistent with the GUI:

http://hg.savannah.gnu.org/hgweb/octave/rev/02500c701539

Pantxo Diribarne <pantxo>
Project Member
Mon 30 Sep 2019 12:59:57 AM UTC, comment #13: 

@Torsten: The additional changesets do make the toolbar even narrower which is nice.  Is it possible to reduce the height of the menubar (File, Edit, View, ...)?  That still feels too large.  If not, then I think we can close this report as enough work has been done on this issue to look passable.

Rik <rik5>
Project Administrator
Sun 29 Sep 2019 04:28:00 PM UTC, comment #12: 

I have pushed two more changesets
http://hg.savannah.gnu.org/hgweb/octave/rev/cfe08c0e2c6d
http://hg.savannah.gnu.org/hgweb/octave/rev/70d9746e9011
for an additional reduction of vertical space used by the toolbar.

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Tue 21 May 2019 03:51:28 AM UTC, comment #11: 

Attached is a screenshot capturing the before and after for this changeset.  The third menubar which consists of icons is definitely more compact.

If I had my wish, I would still reduce the space above and below the main menubar which has the text entries "File", "Edit", ...


Rik <rik5>
Project Administrator
Fri 17 May 2019 05:18:57 PM UTC, comment #10: 

I forgot to mention that the editor tabs can be placed left or right to the edit area, which also frees vertical space.

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Fri 17 May 2019 05:04:22 AM UTC, comment #9: 

The automatically adapted space for the line numbers depending on the number of lines in the document is done in the octave editor, not by qt or qscintilla. The space seems to be wider than required since there is also space for the markers. The space consumed by the line numbers can be reduced by tuning their font size in the preferences tab "Editor".

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Thu 16 May 2019 08:58:01 PM UTC, comment #8: 

I have pushed changeset http://hg.savannah.gnu.org/hgweb/octave/rev/e83d3161b256 reducing some vertical space in the editor widget. I will also have a look at the line number issue.

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Wed 24 Apr 2019 04:02:16 PM UTC, comment #7: 

Last comments on this bug were from July, 2018, but there still seems to be excessive vertical whitespace between menubars.

It isn't that the existing UI is unworkable, but it would feel nicer if the spacing could be made smaller.  I also agree that the the spacing on the left for line numbers would be nicer if it was smaller.  The space seems to automatically grow if the number of lines grows.  This seems to be something Qt is doing so I don't think Octave needs to budget space for it.

Rik <rik5>
Project Administrator
Sun 01 Jul 2018 08:31:39 AM UTC, comment #6: 

That works! I was just looking for it by right-clicking the toolbar directly. I'll spend some time going through the Preferences to see what else I may be missing.

Thanks.

Andrew Janke <apjanke>
Sun 01 Jul 2018 08:30:10 AM UTC, comment #5: 

a "Small Icons" option exists in the preferences dialog, tab "General". It would be no problem to add a preference for the toolbar's visibility.

Torsten Lilge <ttl>
Project MemberIn charge of this item.
Sun 01 Jul 2018 07:19:03 AM UTC, comment #4: 

Related: on macOS with a retina display, I see similar excessive-looking whitespace, plus the toolbar icons are quite big. While this only eats up a couple lines of text, it looks kind of "junior". It would be nice to have a "Small Icons" option, and/or the ability to turn off the editor toolbar altogether. (Maybe that already exists, and I just couldn't find it.)

Screencaps attached.

Andrew Janke <apjanke>
Wed 16 May 2018 07:46:33 PM UTC, comment #3: 

What I think I see is that there's lots of whitespace above and below text, IOW related to font rendering rather than various bars and dummy lines.

Philip Nienhuis <philipnienhuis>
Project Member
Wed 16 May 2018 05:24:12 PM UTC, comment #2: 

I agree with most of your markups for the "gray" space.  There doesn't seem to be good use of space in the octave_dock_widget (that's the object in the code comprising the floatable main widgets, it's derived from a label_dock_widget which in turn is derived from a QDockWidget).  It's been a bit of a struggle getting these things to work in all platforms (KDE in particular) and sort out the desired behavior.  Layout and spacing has been the low priority.

We can't get rid of the second title line though because that title contains the "dock" box (or double-click on the title line).  Without that "dock" box there is no way of putting that floated widget back into the QMainwindow.  Qt has absolutely no control over the very top title line which is part of the OS Window Manager.  I think that is why they devised this secondary title bar option

Perhaps there is one trick to pursue (but I haven't the time).  If the Qt layout could be shifted so that the tab area extends up into the title bar (remove the "Editor" title since it is already in the Window Manager titlebar (no guarantee of that, though, I suppose) then it might look like the dock-box is level with the tabs rather than using up its own line.

Dan Sebald <sebald>
Tue 15 May 2018 07:23:54 PM UTC, comment #1: 

+1
Trimming (vertical) whitespace on today's wide-screen laptops is always a good idea IMO.
But to be honest, on my Windows boxes the excess whitespace isn't so very conspicuous.

Philip Nienhuis <philipnienhuis>
Project Member
Mon 14 May 2018 07:16:55 PM UTC, original submission:  

Since recompiling with Qt5 (instead of Qt4) it seems the amount of whitespace has increased in the Editor. I was wondering if someone on the GUI side could make a "compact" option.

On my little laptop, the menus and title bars take up 40% of the useable space. This is already with small icons. They seem to be very generously surrounded with extra pixels and in fact, for me, the dock widget titlebar could be toggled off completely.

See pic.

Ceral Paquet <octavebugs>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46938:  Menu_spacing.png added by rik5 (14KiB - image/png)
file #44472:  editor_docked_macOS_retina.png added by apjanke (241KiB - image/png - screenshots from Octave 4.4.0 on macOS 10.13.5 with Retina display)
file #44473:  editor_undocked_macOS_retina.png added by apjanke (113KiB - image/png - screenshots from Octave 4.4.0 on macOS 10.13.5 with Retina display)
file #44157:  editor_undocked.png added by octavebugs (71KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by apjanke (Updated the item)
  • -email is unavailable- added by sebald (Posted a comment)
  • -email is unavailable- added by octavebugs (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 16 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-10-07 rik5 StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2019-05-21 rik5 Attached File- => Added Menu_spacing.png, #46938
    2019-05-16 ttl StatusConfirmed => Ready For Test
        Assigned toNone => ttl
    2019-04-24 rik5 Item GroupNone => Feature Request
        StatusNone => Confirmed
        Release4.4.0 => dev
    2018-07-01 apjanke Attached File- => Added editor_docked_macOS_retina.png, #44472
        Attached File- => Added editor_undocked_macOS_retina.png, #44473
    2018-05-17 mtmiller Carbon-CopyRemoved 80942 => -
    2018-05-17 mtmiller CategoryNone => GUI
        Severity3 - Normal => 1 - Wish
        Priority5 - Normal => 3 - Low
    2018-05-15 octavebugs Attached File- => Added editor_undocked_commented.png, #44159
    2018-05-14 octavebugs Attached File- => Added editor_undocked.png, #44157

    Back to the top


    Powered by Savane 3.5