(
Jump to the original submission)
I pushed the following changeset for the -Walloc-size-larger-than= warning:
http://hg.savannah.gnu.org/hgweb/octave/rev/2dad85fe6b8b
|
Oh, and after actually reading the manual description of the -Walloc-size-larger-than= option, I see the problem with the new expression. NEED is signed and not checked to ensure that it is always greater than 0, so could be -1, which when cast to size_t would be greater than SIZE_MAX / 2. I'm surprised this is the only warning we see about that kind of issue in Octave.
|
I pushed the following changeset on stable:
http://hg.savannah.gnu.org/hgweb/octave/rev/bbc47fb89973
Closing this report as fixed.
|
The other warning is gone. So we could close this bug and open another one?
Dmitri.
--
|
I saw that message about getmemi in your earlier log but I couldn't figure out where or how that situation could happen.
|
Now i see this:
Dmitri.
--
|
Except that the test should be _GNUC_ < 8, not 7.
|
Does the attached patch work for you?
(file #44136)
|
Ugh, GCC 8 has changed the Fortran calling ABI:
> Character variables longer than HUGE(0) elements are now possible on 64-bit targets. Note that this changes the procedure call ABI for all procedures with character arguments on 64-bit targets, as the type of the hidden character length argument has changed. The hidden character length argument is now of type INTEGER(C_SIZE_T).
(from https://gcc.gnu.org/gcc-8/changes.html)
So we need to make F77_CHAR_ARG_LEN_TYPE conditional on the version of GCC now.
|
I see in gcc-lto-fedora buildbot:
http://buildbot.octave.org:8011/#/builders/25/builds/1/steps/5/logs/stdio
(around line 8200)
Dmitri.
--
|
(Note: upload size limit is set to 16384 kB, after insertion of the required
escape characters.)
Attach Files:
Comment:
Depends on the following items: None found
Items that depend on this one: None found
Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.
Only project members can vote.