bugGNU Octave - Bugs: bug #53872, type of 'xilaenv_' does not match...

 
 

bug #53872: type of 'xilaenv_' does not match original declaration

Submitted by:  Dmitri A. Sergatskov <dasergatskov>
Submitted on:  Thu 10 May 2018 01:55:42 PM UTC  
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 11 May 2018 03:31:55 PM UTC, comment #9:

I pushed the following changeset for the -Walloc-size-larger-than= warning:

http://hg.savannah.gnu.org/hgweb/octave/rev/2dad85fe6b8b

John W. Eaton <jwe>
Project Administrator
Fri 11 May 2018 01:18:22 AM UTC, comment #8:

Oh, and after actually reading the manual description of the -Walloc-size-larger-than= option, I see the problem with the new expression. NEED is signed and not checked to ensure that it is always greater than 0, so could be -1, which when cast to size_t would be greater than SIZE_MAX / 2. I'm surprised this is the only warning we see about that kind of issue in Octave.

John W. Eaton <jwe>
Project Administrator
Thu 10 May 2018 08:21:34 PM UTC, comment #7:

I pushed the following changeset on stable:

http://hg.savannah.gnu.org/hgweb/octave/rev/bbc47fb89973

Closing this report as fixed.

John W. Eaton <jwe>
Project Administrator
Thu 10 May 2018 07:58:29 PM UTC, comment #6:

The other warning is gone. So we could close this bug and open another one?

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Thu 10 May 2018 07:52:58 PM UTC, comment #5:

I saw that message about getmemi in your earlier log but I couldn't figure out where or how that situation could happen.

John W. Eaton <jwe>
Project Administrator
Thu 10 May 2018 07:22:26 PM UTC, comment #4:

Now i see this:

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Thu 10 May 2018 05:57:39 PM UTC, comment #3:

Except that the test should be _GNUC_ < 8, not 7.

John W. Eaton <jwe>
Project Administrator
Thu 10 May 2018 05:56:59 PM UTC, comment #2:

Does the attached patch work for you?

(file #44136)

John W. Eaton <jwe>
Project Administrator
Thu 10 May 2018 05:25:41 PM UTC, comment #1:

Ugh, GCC 8 has changed the Fortran calling ABI:

> Character variables longer than HUGE(0) elements are now possible on 64-bit targets. Note that this changes the procedure call ABI for all procedures with character arguments on 64-bit targets, as the type of the hidden character length argument has changed. The hidden character length argument is now of type INTEGER(C_SIZE_T).


(from https://gcc.gnu.org/gcc-8/changes.html)

So we need to make F77_CHAR_ARG_LEN_TYPE conditional on the version of GCC now.

Mike Miller <mtmiller>
Project Administrator
Thu 10 May 2018 01:55:42 PM UTC, original submission:

I see in gcc-lto-fedora buildbot:
http://buildbot.octave.org:8011/#/builders/25/builds/1/steps/5/logs/stdio

(around line 8200)

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #44136:  char-arg-len-diff.txt added by jwe (657B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Updated the item)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by dasergatskov (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-05-10 jwe StatusNone => Fixed
        Open/ClosedOpen => Closed
    2018-05-10 jwe Attached File- => Added char-arg-len-diff.txt, #44136

    Back to the top


    Powered by Savane 3.3