bugGNU Octave - Bugs: bug #53761, code under...

 
 

bug #53761: code under liboctave/external/ordered-qz/ might be non-free

Submitted by:  Sébastien Villemot <svillemot>
Submitted on:  Thu 26 Apr 2018 02:28:06 PM UTC  
 
Category:  Libraries Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  4.4.0 Operating System:  Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 24 Jul 2018 05:53:41 PM UTC, comment #8:

The patch was pushed several weeks ago. Marking as fixed and closing report.

Rik <rik5>
Project Administrator
Tue 10 Jul 2018 07:17:23 PM UTC, comment #7:

I pushed your change on stable and merged with default:

http://hg.savannah.gnu.org/hgweb/octave/rev/da2b38b7a077

John W. Eaton <jwe>
Project Administrator
Sun 13 May 2018 10:39:44 AM UTC, comment #6:

I attach the patch that implements this (and adds a few tests).

I tested it on top of the default branch, but it should also apply on stable.

(file #44146)

Sébastien Villemot <svillemot>
Tue 01 May 2018 08:59:18 PM UTC, comment #5:

I have a draft patch that solves the issue, basically replacing all the non-free code by a single call to DGTSEN. I hope to finalize it soon.

Sébastien Villemot <svillemot>
Thu 26 Apr 2018 05:10:23 PM UTC, comment #4:

OK, that's good. There are probably others that are more familiar with the ARPACK layout, so I'll defer. However, since the libraries are already included, it may be an easy task to replace the routine calls and discard the whole directory.

Dan Sebald <sebald>
Thu 26 Apr 2018 04:22:37 PM UTC, comment #3:

Actually ?TGSEN (not ?TRSEN).

Sébastien Villemot <svillemot>
Thu 26 Apr 2018 04:21:50 PM UTC, comment #2:

The LAPACK ?GGES and ?TRSEN functions should indeed provide equivalent functionality.

Sébastien Villemot <svillemot>
Thu 26 Apr 2018 04:20:02 PM UTC, comment #1:

I wonder if these files could be substituted with an ARPACK/BLAS equivalent, or something close then use some type of post-transformation on the matrices.

Dan Sebald <sebald>
Thu 26 Apr 2018 02:28:06 PM UTC, original submission:

The code under liboctave/external/ordered-qz/ corresponds to file 590 of the collected algorithms from ACM:
http://www.netlib.org/toms/

It therefore looks like it's non-free, since it's distributed under ACM Software License Agreement which forbids commercial redistribution.

Sébastien Villemot <svillemot>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #44146:  dtgsen.patch added by svillemot (46KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by sebald (Posted a comment)
  • -email is unavailable- added by svillemot (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-07-24 rik5 StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2018-07-10 jwe StatusIn Progress => Ready For Test
    2018-05-13 svillemot Attached File- => Added dtgsen.patch, #44146
    2018-05-01 mtmiller StatusNone => In Progress
    2018-05-01 mtmiller CategoryNone => Libraries
        Item GroupNone => Other
        Release4.3.91 => 4.4.0

    Back to the top


    Powered by Savane 3.3