(
Jump to the original submission)
The patch was pushed several weeks ago. Marking as fixed and closing report.
|
I pushed your change on stable and merged with default:
http://hg.savannah.gnu.org/hgweb/octave/rev/da2b38b7a077
|
I attach the patch that implements this (and adds a few tests).
I tested it on top of the default branch, but it should also apply on stable.
(file #44146)
|
I have a draft patch that solves the issue, basically replacing all the non-free code by a single call to DGTSEN. I hope to finalize it soon.
|
OK, that's good. There are probably others that are more familiar with the ARPACK layout, so I'll defer. However, since the libraries are already included, it may be an easy task to replace the routine calls and discard the whole directory.
|
Actually ?TGSEN (not ?TRSEN).
|
The LAPACK ?GGES and ?TRSEN functions should indeed provide equivalent functionality.
|
I wonder if these files could be substituted with an ARPACK/BLAS equivalent, or something close then use some type of post-transformation on the matrices.
|
The code under liboctave/external/ordered-qz/ corresponds to file 590 of the collected algorithms from ACM:
http://www.netlib.org/toms/
It therefore looks like it's non-free, since it's distributed under ACM Software License Agreement which forbids commercial redistribution.
|
(Note: upload size limit is set to 16384 kB, after insertion of the required
escape characters.)
Attach Files:
Comment:
Depends on the following items: None found
Items that depend on this one: None found
Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.
Only project members can vote.