bugGNU Octave - Bugs: bug #53540, compile error: libgui fails to...

 
 

bug #53540: compile error: libgui fails to build with Qt 4

Submitted by:  Hartmut <hardy>
Submitted on:  Sun 01 Apr 2018 12:53:50 PM UTC  
 
Category:  Configuration and Build System Severity:  4 - Important
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  Mike Miller <mtmiller>
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 03 Apr 2018 05:39:20 PM UTC, comment #6: 

I have recompiled the "stable" branch with the patch from comment #5 (hg id daff5efe062f to be precise). And now it compiles without any problems on my (Qt4) machine. Also "make test" passes with 0 failures.

Thanks for the fix!

Hartmut <hardy>
Mon 02 Apr 2018 11:03:27 PM UTC, comment #5: 

Fixed on the stable branch

https://hg.savannah.gnu.org/hgweb/octave/rev/c0d48cfbb59a

Builds for me now with Qt 4.8.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Mon 02 Apr 2018 10:04:03 PM UTC, comment #4: 

Currently testing the attached change against Qt 4.8 to use liboctave system functions instead of the Qt equivalents.

(file #43777)

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sun 01 Apr 2018 07:45:43 PM UTC, comment #3: 

Another error when building with Qt 4

In file included from /usr/include/qt4/QtCore/QThread:1:0,
                 from ../libgui/graphics/ObjectProxy.cc:29:
/usr/include/qt4/QtCore/qthread.h: In member function 'uint8NDArray QtHandles::ObjectProxy::get_pixels()':
/usr/include/qt4/QtCore/qthread.h:116:17: error: 'static void QThread::msleep(long unsigned int)' is protected
     static void msleep(unsigned long);
                 ^
../libgui/graphics/ObjectProxy.cc:137:29: error: within this context
         QThread::msleep (100);
                             ^
In file included from /usr/include/qt4/QtCore/QThread:1:0,
                 from ../libgui/graphics/ObjectProxy.cc:29:
/usr/include/qt4/QtCore/qthread.h:116:17: error: 'static void QThread::msleep(long unsigned int)' is protected
     static void msleep(unsigned long);
                 ^
../libgui/graphics/ObjectProxy.cc:141:33: error: within this context
             QThread::msleep (200);
                                 ^

These could be replaced easily with calls to octave_sleep.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sun 01 Apr 2018 05:55:36 PM UTC, comment #2: 

It would be better to use octave::sys::recursive_rmdir.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sun 01 Apr 2018 04:59:09 PM UTC, comment #1: 

http://doc.qt.io/qt-5/qdir.html#removeRecursively

"This function was introduced in Qt 5.0."

Dan Sebald <sebald>
Sun 01 Apr 2018 12:53:50 PM UTC, original submission:  

I have tried to compile the current "stable" branch of the Octave repository (hg id 53440f9bffba) on a Ubuntu 14.04 computer. 

I get the following compiler error during "make":

  CXX      libgui/src/libgui_src_libgui_src_la-documentation.lo
libgui/src/documentation.cc: In destructor ‘virtual octave::documentation::~documentation()’:
libgui/src/documentation.cc:204:20: error: ‘class QDir’ has no member named ‘removeRecursively’
             tmpdir.removeRecursively ();
                    ^
Makefile:16967: die Regel für Ziel „libgui/src/libgui_src_libgui_src_la-documentation.lo“ scheiterte
make[2]: *** [libgui/src/libgui_src_libgui_src_la-documentation.lo] Fehler 1

Compiling worked fine with a couple of older Octave versions, e.g. the 4.2.2 release.

I am still using Qt4 libraries. I ran bootstrap and configure without any options.

Let me know which other information you need to hunt this down.

Hartmut <hardy>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43777:  libgui.diff added by mtmiller (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by sebald (Posted a comment)
  • -email is unavailable- added by hardy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-02 mtmiller StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
    2018-04-02 mtmiller Attached File- => Added libgui.diff, #43777
        StatusConfirmed => In Progress
        Assigned toNone => mtmiller
    2018-04-01 mtmiller Summarycompile error: class QDir has no member named removeRecursively with Qt 4 => compile error: libgui fails to build with Qt 4
    2018-04-01 mtmiller Severity3 - Normal => 4 - Important
        Item GroupNone => Build Failure
        StatusNone => Confirmed
        Summarycompile error: class QDir has no member named removeRecursively => compile error: class QDir has no member named removeRecursively with Qt 4

    Back to the top


    Powered by Savane 3.5