bugGNU Octave - Bugs: bug #53441, magic.m:Not producing...

 
 

bug #53441: magic.m:Not producing warning,error where MATLAB doing for negative no

Submitter:  Dildar Sk <hodor123456>
Submitted:  Fri 23 Mar 2018 01:32:12 PM UTC
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Missed Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Dildar Sk Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Thu 12 Apr 2018 09:02:08 PM UTC, comment #2: 

I modified your patch to make the test (if n < 0) part of the if/elseif tree that already existed.  In error messages, the first thing is to identify the function  with "function_name:".  I changed your error message to have the prefix "magic:" and I capitalized 'n' to 'N' because that is how the variable is displayed to users in the documentation when they type 'help magic'.  You can see the full changeset here (http://hg.savannah.gnu.org/hgweb/octave/rev/27e6b38571d3).

Marking as fixed and closing report.

Rik <rik5>
Project Administrator
Fri 23 Mar 2018 01:37:04 PM UTC, comment #1: 

Updated the function.
Updated tests.
Patch attached.

(file #43645)

Dildar Sk <hodor123456>
Fri 23 Mar 2018 01:32:12 PM UTC, original submission:  

In MATLAB,

>> magic (-2)
Subscript indices must either be real positive integers or
logicals.

Error in magic (line 35)
   M([i; i+p],j) = M([i+p; i],j);

Where in Octave,

>> magic (-2)
ans = [](0x0)

Dildar Sk <hodor123456>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43645:  magic.patch added by hodor123456 (883B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by hodor123456 (Submitted the item)
  • -email is unavailable- added by hodor123456
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-12 rik5 StatusNone Fixed
        Open/ClosedOpen Closed
    2018-03-23 hodor123456 Attached File- Added magic.patch, #43645
    2018-03-23 hodor123456 Carbon-Copy- Added -email is unavailable-

    Back to the top


    Powered by Savane 3.9