bugGNU Octave - Bugs: bug #53429, Unnecessary underlining of text in...

 
 

bug #53429: Unnecessary underlining of text in selected line of Command History

Submitter:  Rik <rik5>
Submitted:  Thu 22 Mar 2018 07:24:19 PM UTC
   
 
Category:  GUI Severity:  1 - Wish
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 02 Mar 2019 10:02:05 PM UTC, comment #4: 

This seems to have fixed itself since I originally reported it in March, 2018.  I'm going to close the report.

Rik <rik5>
Group administrator
Thu 22 Mar 2018 09:17:18 PM UTC, comment #3: 

I assume lineEdit is this Widget class: https://doc.qt.io/qt-5/qlineedit.html.

I didn't see anything obvious that would explain the underlining.

Rik <rik5>
Group administrator
Thu 22 Mar 2018 08:05:49 PM UTC, comment #2: 

I've looked at both history-dock-widget.cc and file-dock-widget.cc and I don't see in either case that anything special is done to affect the highlighting.  It creates a selector model and pretty much uses the default settings.

However, I think what is unique to history-dock-widget.cc is that it has that extra layer of a Filter [x].  That is, the history list is passed through a filter first (and even if the Filter is not selected, I think the list goes through the filter).  That filter appears to have an extra "lineEdit"


    if (m_history_list_view->hasFocus ())
      handle_contextmenu_copy (true);
    if (m_filter->lineEdit ()->hasFocus ()
        && m_filter->lineEdit ()->hasSelectedText ())
      {
        QClipboard *clipboard = QApplication::clipboard ();
        clipboard->setText (m_filter->lineEdit ()->selectedText ());
      }


My initial guess would be that the lineEdit() has some properties which include underlining.  This would be something beyond the selector-model's highlighting.  Probably need to find some way of controlling the lineEdit "underline when highlight".

Dan Sebald <sebald>
Thu 22 Mar 2018 07:25:20 PM UTC, comment #1: 

@Dan: I added you to the CC list for this bug, but its not your responsibility to fix it.  I just know that this is possibly related to your other work on the Command History widget.

Rik <rik5>
Group administrator
Thu 22 Mar 2018 07:24:19 PM UTC, original submission:  

This is very minor, but when selecting a line of history in the GUI's Command History window the text itself is underlined.  I don't think that is necessary because the line itself is already accentuated by using a different color.

I've attached a screenshot.

This is with KDE on Linux and Qt5.  It could be something as simple as changing the default CSS settings.

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by sebald (Posted a comment)
  • -email is unavailable- added by rik5
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-02 rik5 StatusNone Fixed
        Open/ClosedOpen Closed
    2018-03-22 rik5 Carbon-Copy- Added sebald
    2018-03-22 rik5 Attached File- Added Underlining_in_Command_Window.png, #43635

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code