bugGNU Octave - Bugs: bug #52823, Review files which lack GPL...

 
 

bug #52823: Review files which lack GPL license header

Submitter:  Rik <rik5>
Submitted:  Sat 06 Jan 2018 04:02:11 PM UTC
   
 
Category:  Documentation Severity:  4 - Important
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 04 Jan 2019 09:42:39 PM UTC, comment #6: 
Rik <rik5>
Group administrator
Fri 04 Jan 2019 08:44:05 PM UTC, comment #5: 

I'm not sure what license and copyright info should be in the remaining files.  I'm OK with leaving them as they are for now so I'm closing this report as fixed.

John W. Eaton <jwe>
Group administrator
Fri 04 Jan 2019 07:41:54 PM UTC, comment #4: 

@jwe: Are the remaining 36 files okay?  Good to close this bug?

Rik <rik5>
Group administrator
Fri 14 Dec 2018 01:19:00 AM UTC, comment #3: 

There is a small list of files left for review over whether they need a GPL license block.  This should be done as part of the 5.0 release

Rik <rik5>
Group administrator
Sat 06 Jan 2018 09:54:13 PM UTC, comment #2: 

I added a GPL license header to certain deserving files in this cset (http://hg.savannah.gnu.org/hgweb/octave/rev/11729ca6eb81).  I took the authors and copyright date from Mercurial.

Attached is the now reduced list of 36 files for possible consideration.  I don't think we need to bother much with adding the license to the metadata of images.  The remaining list is mainly some HTML templates and some GUI files, such as the translation of strings.  I really don't know if they "count" as code or if it makes sense to GPL these.

(file #42861)

Rik <rik5>
Group administrator
Sat 06 Jan 2018 05:03:30 PM UTC, comment #1: 

It looks like it is possible to add text metadata containing a copyright notice to PNG files.  I don't know that I care, but we could do it if others think it is important.

Similarly, we could add copyright notices to the following files, but I'm also OK with not having notices in them.

Makefile fragments
Example code
Test files

I don't think we control the license of these files:

FreeSans font files
QTerminal sources
GUI Icon files (SVG)
External source code in liboctave/external

I'm attaching an updated file with all of the above files removed.  It's still 78 files.


(file #42860)

John W. Eaton <jwe>
Group administrator
Sat 06 Jan 2018 04:02:11 PM UTC, original submission:  

I just updated the GPL licenese header at the top of most Octave files.  As part of that process I created a list of files that are under Mercurial source control, but which do not have any license header.  This is not necessarily a bad thing.  Image files like .png are not text files and can't have a text header.

The list should be reviewed before the next release to see if any headers need to be added.  I notice that most of the sample test code in the tests/ directory does not use liceneses, although occasional files do.

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #42861:  no_gpl_license.v3.list added by rik5 (1KiB - application/octet-stream)
file #42860:  updated_no_gpl_license.list added by jwe (2KiB - application/octet-stream)
file #42859:  no_gpl_license.list added by rik5 (28KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Updated the item)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-01-04 jwe StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2019-01-04 rik5 StatusNone In Progress
    2018-12-14 rik5 Severity3 - Normal 4 - Important
    2018-01-06 rik5 Attached File- Added no_gpl_license.v3.list, #42861
    2018-01-06 jwe Attached File- Added updated_no_gpl_license.list, #42860
    2018-01-06 rik5 Attached File- Added no_gpl_license.list, #42859

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code