bugGNU Octave - Bugs: bug #52802, Settings window should open large...

 
 

bug #52802: Settings window should open large enough to show all tabs

Submitted by:  Rik <rik5>
Submitted on:  Wed 03 Jan 2018 09:48:18 PM UTC  
 
Category:  GUI Severity:  1 - Wish
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 08 Jan 2018 08:17:57 PM UTC, comment #7:

No reliable method found for auto-adjusting the size of the dialog. Therefore, I have added a default with a width of 1000px with changeset http://hg.savannah.gnu.org/hgweb/octave/rev/2245b9183bc5

Torsten <ttl>
Project Member
Fri 05 Jan 2018 10:01:55 PM UTC, comment #6:

Ah, I have not considered different font sizes etc. which makes it hard to define a suitable default size for all systems. So the size should be dynamically calculated from the width of the tab widget.

Torsten <ttl>
Project Member
Fri 05 Jan 2018 05:39:01 PM UTC, comment #5:

@Torsten: Re-sizing the window and then having it remember the larger size works for me. I removed the "geometry" line under "[settings]" in ~/.config/octave/qt-settings and then re-ran but the window is still too small by default. Instead of 795, I need a width of 930 for it to display well. However, If you think that is too large I'm okay with using the slightly smaller default. I do think you should push your change at some point.

Rik <rik5>
Project Administrator
Fri 05 Jan 2018 04:53:28 PM UTC, comment #4:

Sahil, "by defaults" means that this is the default size of the dialog. When there is a size from the previous settings dialog stored in the settings file this one is used instead the default one.

Torsten <ttl>
Project Member
Fri 05 Jan 2018 07:55:02 AM UTC, comment #3:

ttl, I applied your patch (ofcourse after discarding my own patch), but the window size looks the same as earlier to me. May be if anyone else can confirm that the window is now sufficiently large by default.

Sahil Yadav <batterylow>
Thu 04 Jan 2018 09:03:13 PM UTC, comment #2:

Sail, thanks for the patch. However, I think, the minimal size is too large now and we should not prevent the user from choosing a smaller dialog window. I would prefer to set a default size when the settings dialog is opened and the settings file does not yet contain the last geometry (i.e. the desired one) to restore.

Please find a patch that implements a sufficiently large default size.

@Rik: Are you able to resize the settings dialog instead of horizontally scrolling the tabs?

(file #42836)

Torsten <ttl>
Project Member
Thu 04 Jan 2018 05:36:58 PM UTC, comment #1:

I was able to change the default size such that "Variable Editor" is completely visible now. But the problem is, the minimum width of the settings dialog box is now the same as the default width (795px to be exact), which earlier was 400px(minimum width).
I tried all the possible values of the Horizontal Policy in sizePolicy attribute from being "fixed" to "ignored" for the outer most settings_dialog layer.
As for now, i think it should cater our need (unless the user really wants to shrink the settings dialog box so that he needs to scroll right/left to see the hidden parts).
Others are welcomed to point out where I've been missing.

PS: I wasn't able to correctly format the comment with verbatim tags and so posted it raw.

(file #42828)

Sahil Yadav <batterylow>
Wed 03 Jan 2018 09:48:18 PM UTC, original submission:

This is very minor, but when opening up the preferences dialog in the GUI the "Variable Editor" tab is not displayed and one has to scroll the tabs to the right to see it. It makes sense just to create the Preferences window a little larger so that everything can be seen.

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #42836:  bug52802_v1.diff added by ttl (1KiB - text/x-patch)
file #42828:  52802.diff added by batterylow (4KiB - text/x-patch - changes in settings-dialog.ui)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Updated the item)
  • -email is unavailable- added by batterylow (Updated the item)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-01-08 ttl StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2018-01-05 rik5 StatusNone => Patch Submitted
    2018-01-04 ttl Attached File- => Added bug52802_v1.diff, #42836
    2018-01-04 batterylow Attached File- => Added 52802.diff, #42828

    Back to the top


    Powered by Savane 3.3