bugGNU Octave - Bugs: bug #51989, [octave forge] (odepkg) Wrong...

 
 

bug #51989: [octave forge] (odepkg) Wrong expected value in unit test

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Mon 11 Sep 2017 09:29:06 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  None Assigned to:  cdf
Originator Name:  Open/Closed:  * Open
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 11 Sep 2017 02:34:44 PM UTC, comment #7: 

I see.  The compatibility with Octave 4.2 is an important issue, indeed, since we are packaging odepkg for Debian.  I prefer to wait until the next upstream release, though. Do you know whether this is going to happen soon?

At any rate, users are warned about the function overloading once they load odepkg 0.8.5 package in Octave 4.2.

Rafael Laboissière <rlaboiss>
Mon 11 Sep 2017 02:22:10 PM UTC, comment #6: 

Even though it might be working I'm not sure it is a
good idea to install odepkg 0.8.5 in Octave 4.2 as some
functions (actually the most commonly used ones, e.g. ode45 and odeset) were moved from octave-forge into Octave core
in 4.2.0, so loading the package will overload these
functions.

The versions of these functions in Octave core also contain
substantial algorithm and interface improvements so overloading
them will be a sort of downgrade.

Carlo de Falco <cdf>
Group Member
Mon 11 Sep 2017 01:52:11 PM UTC, comment #5: 

I am using version 4.2.1 of Octave.  The package is working perfectly for me.  All tests succeeded, besides that one that I inidicated in my original bug report.

Rafael Laboissière <rlaboiss>
Mon 11 Sep 2017 01:03:53 PM UTC, comment #4: 

And what version of Octave?

I have been told odepkg does not work with current
Octave releases (4.2.x) ...

Anyway it would be helpful if you could check whether the same problem also applies to odepkg 0.9.1 which is as of yet unreleased.

If you are using Octave 4.2.x you can install
a development snapshot as follows:


[fname, success] = urlwrite ("https://bitbucket.org/odepkg/odepkg/get/default.tar.gz", [P_tmpdir "odepkg.tar.gz"]);
assert (success)
pkg ("install", fname)


If you are using the development version of Octave you can use
[fname, success] = urlwrite ("https://bitbucket.org/odepkg/odepkg/get/octave43.tar.gz", [P_tmpdir "odepkg.tar.gz"]);
assert (success)
pkg ("install", fname)


If you have an older version of Octave please upgrade before trying this.


thanks again!

Carlo de Falco <cdf>
Group Member
Mon 11 Sep 2017 12:57:51 PM UTC, comment #3: 

version 0.8.5

Rafael Laboissière <rlaboiss>
Mon 11 Sep 2017 12:07:51 PM UTC, comment #2: 

Hi, thanks for the report!
What version of odepkg did you test?

Carlo de Falco <cdf>
Group Member
Mon 11 Sep 2017 11:20:40 AM UTC, comment #1: 

[Something went wrong with the formatting of my bug report.  Here is what I meant:]

One of the unit tests in file odepkg_testsuite_calcmescd.m has a
wrong expected value:

%!assert (odepkg_testsuite_calcmescd ([1, 2, 3], [1, 2, 3], NaN, NaN), Inf);

It should be actually:

%!assert (odepkg_testsuite_calcmescd ([1, 2, 3], [1, 2, 3], NaN, NaN), NaN);

Rafael Laboissière <rlaboiss>
Mon 11 Sep 2017 09:29:06 AM UTC, original submission:  

One of the unit tests in file odepkg_testsuite_calcmescd.m has a wrong expected value:


%!assert (odepkg_testsuite_calcmescd ([1, 2, 3], [1, 2, 3], NaN, NaN), Inf);


It should be actually:


%!assert (odepkg_testsuite_calcmescd ([1, 2, 3], [1, 2, 3], NaN, NaN), NaN);


Rafael Laboissière <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by cdf (Posted a comment)
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-09-11 cdf Assigned toNone cdf

    Back to the top

    Powered by Savane 3.13-b921.
    Corresponding source code