bugGNU Octave - Bugs: bug #51803, openjdk 9 no longer allows...

 
 

bug #51803: openjdk 9 no longer allows building with -source 1.3 -target 1.3

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Sun 20 Aug 2017 04:51:19 PM UTC  
 
Category:  Configuration and Build System Severity:  4 - Important
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  Mike Miller <mtmiller>
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Wed 23 Aug 2017 06:42:30 AM UTC, comment #6:

I fixed this by setting the new source and target options to 1.6. I also changed JNI_VERSION_1_2 to JNI_VERSION_1_6 thanks to a suggestion by Ernst on the mailing list.

https://hg.savannah.gnu.org/hgweb/octave/rev/20c83f619102

I also dropped octave.jar from the source distribution

https://hg.savannah.gnu.org/hgweb/octave/rev/712736d43124

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sun 20 Aug 2017 11:33:01 PM UTC, comment #5:

I'm actually rethinking keeping the options, and maybe changing them to 1.6 for now. But dropping octave.jar is still valid. I just checked my mxe-octave build logs and it also uses the build host JDK to recompile the Java sources and create octave.jar.

If I build Octave using Java 8 without specifying these options, then Octave can only use Java 8 or newer. This may be very important, especially for the Windows distribution, and maybe for other OS if we ever address bug #40111.

So I think we do need to keep specifying a minimum to make sure the bytecode is backwards compatible.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sun 20 Aug 2017 11:23:04 PM UTC, comment #4:

@Mike: I saw your comment about Java on the Maintainer's list. It makes sense to me to drop distribution of the binary octave.jar and the other changes as well.

Rik <rik5>
Project Administrator
Sun 20 Aug 2017 06:27:13 PM UTC, comment #3:

I saw this test failure as well, but since Java 9 is prerelease at this point, I don't think it's worth addressing until we know what the actual version number will look like once an actual release occurs.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sun 20 Aug 2017 06:15:08 PM UTC, comment #2:

With some risk of hijacking the bug report.
I build octave with java-9 on Fedora and now some off the (java) tests are failing:

So if we to allow java-9 as well as older version this check should be modified.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Sun 20 Aug 2017 06:02:18 PM UTC, comment #1:

I'm planning on pushing the attached change, pending feedback on the maintainers list (waiting a couple days to see if anyone cares).

This will drop the source and target options and remove octave.jar from the source distribution.

(file #41592)

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sun 20 Aug 2017 04:51:19 PM UTC, original submission:

I have updated to OpenJDK 9 on Debian, and building Octave now results in the following errors

I think the options should simply be dropped at this point, I'll post on the maintainers list to ask for feedback on the slightly bigger issue.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #41592:  java.diff added by mtmiller (881B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-23 mtmiller StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2017-08-20 mtmiller Attached File- => Added java.diff, #41592
        StatusNone => Patch Submitted
        Assigned toNone => mtmiller

    Back to the top


    Powered by Savane 3.3