bugGNU Octave - Bugs: bug #50571, functions that need nanflag...

 
 

bug #50571: functions that need nanflag options for compatibility

Submitter:  Ceral Paquet <octavebugs>
Submitted:  Fri 17 Mar 2017 09:41:35 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Matlab Compatibility
Status:  Need Info Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 13 Apr 2023 10:55:20 PM UTC, comment #7: 

now that mean, median, and std support NANFLAG, I pushed a version of normalize.m that compatibly handles nan values as
http://hg.savannah.gnu.org/hgweb/octave/rev/ce36dddf5427

note that it still has a workaround for sum not supporting nanflag, but it's a simple enough fix that normalize is now fully compatible.

as i get a chance I'll try to work through some of the other functions that may be easier to update, however, this will probably hang around until the lower level compiled functions are updated.

Nicholas Jankowski <nrjank>
Group Member
Tue 21 Mar 2023 12:50:55 AM UTC, comment #6: 

a version of cov that handles nanflag has been pushed to core with bug #50583

Nicholas Jankowski <nrjank>
Group Member
Thu 02 Mar 2023 04:34:55 PM UTC, comment #5: 

noting a number of the movX functions are in this list, is it possible they can inherit the nanflag functinality from the primary function (e.g., mean-> movmean).  Understanding if its simple enough it might warrant handling internally to reduce calling overhead.

Nicholas Jankowski <nrjank>
Group Member
Wed 01 Mar 2023 06:33:45 PM UTC, comment #4: 

patch #10314 was pushed to default (ported from statistics to core) that includes matlab compatible mean, median, var, and std handling of the nanflag opton. most of the other comment #0 functions mentioned still unchanged.

Nicholas Jankowski <nrjank>
Group Member
Wed 26 Oct 2022 09:16:08 PM UTC, comment #3: 

adding recently implemented 'normalize.m' to the list of functions affected by this, indirectly through mean, median, and std/var.

Nicholas Jankowski <nrjank>
Group Member
Tue 23 Nov 2021 09:27:47 PM UTC, comment #2: 

might be worth going through this list to determine if nanflag been implemented, or even just patches submitted, since this was posed in 2017.  (e.g., there' a patch sitting at bug #50007 for min and max). 

re-titling to indicate that this bug covers far more than just sum.

Nicholas Jankowski <nrjank>
Group Member
Tue 01 Dec 2020 04:45:25 PM UTC, comment #1: 

Changing target release to "dev" because imho such a change shouldn't be done for a dot release.

Markus Mützel <mmuetzel>
Group administrator
Fri 17 Mar 2017 09:41:35 PM UTC, original submission:  

This is basically the same issue as bug #50007.

Matlab provides optional string arguments to some core functions that allow you to omit NaN values. Please excuse the cut & paste job... the result of a search for "nanflag" in the matlab online documentation.

I'm fairly sure most of these derive from the fundamental sum, median, min, max functions so the list is almost certainly redundant.



median - Median value of array
This MATLAB function returns the median value of A.

min - Smallest elements in array
This MATLAB function returns the smallest elements of A.

max - Largest elements in array
This MATLAB function returns the largest elements of A.

sum - Sum of array elements
This MATLAB function returns the sum of the elements of A along the first array dimension whose size does not equal 1.

mean - Average or mean value of array
This MATLAB function returns the mean of the elements of A along the first array dimension whose size does not equal 1.

std - Standard deviation
This MATLAB function returns the standard deviation of the elements of A along the first array dimension whose size does not equal 1.

bounds - Smallest and largest elements
This MATLAB function returns the smallest element S and largest element L of an array.

cov - Covariance
This MATLAB function returns the covariance.

var - Variance
This MATLAB function returns the variance of the elements of A along the first array dimension whose size does not equal 1.

prod - Product of array elements
This MATLAB function returns the product of the array elements of A.

cummin - Cumulative minimum
This MATLAB function returns the cumulative minimum elements of A.

cummax - Cumulative maximum
This MATLAB function returns the cumulative maximum elements of A.

cumprod - Cumulative product
This MATLAB function returns the cumulative product of A starting at the beginning of the first array dimension in A whose size does not equal 1.

cumsum - Cumulative sum
This MATLAB function returns the cumulative sum of A starting at the beginning of the first array dimension in A whose size does not equal 1.

movmean - Moving mean
This MATLAB function returns an array of local k-point mean values, where each mean is calculated over a sliding window of length k across neighboring elements of A.

movmax - Moving maximum
This MATLAB function returns an array of local k-point maximum values, where each maximum is calculated over a sliding window of length k across neighboring elements of A.

movmedian - Moving median
This MATLAB function returns an array of local k-point median values, where each median is calculated over a sliding window of length k across neighboring elements of A.

movmin - Moving minimum
This MATLAB function returns an array of local k-point centered minimum values, where each minimum is calculated over a sliding window of length k across neighboring elements of A.

movsum - Moving sum
This MATLAB function returns an array of local k-point sums, where each sum is calculated over a sliding window of length k across neighboring elements of A.

medfilt1 - 1-D median filtering
This MATLAB function applies a third-order one-dimensional median filter to the input vector, x.

movstd - Moving standard deviation
This MATLAB function returns an array of local k-point standard deviation values.

movvar - Moving variance
This MATLAB function returns an array of local k-point variance values, where each variance is calculated over a sliding window of length k across neighboring elements of A.

movprod - Moving product
This MATLAB function returns an array of local k-point products, where each product is calculated over a sliding window of length k across neighboring elements of A.

movmad - Moving median absolute deviation
This MATLAB function returns an array of local k-point median absolute deviations (MADs), where each MAD is calculated over a sliding window of length k across neighboring elements of A.

smoothdata - Smooth noisy data
This MATLAB function returns a moving average of the elements of a vector using a fixed window length that is determined heuristically.


Ceral Paquet <octavebugs>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Digest:
   bug dependencies.

Items that depend on this one

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by octavebugs (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-23 nrjank StatusConfirmed Need Info
        Summarysum with omitnan and includenan arguments functions that need nanflag options for compatibility
    2020-12-03 mtmiller Carbon-CopyRemoved 80942 -
    2020-12-01 mmuetzel Release4.4.0 dev
        Operating SystemGNU/Linux Any
    2020-02-21 rik5 Dependencies- bugs #57871 is dependent
    2018-05-03 siko1056 StatusNone Confirmed
        Release4.2.1 4.4.0
    2018-03-30 mtmiller CategoryNone Octave Function
        Item GroupNone Matlab Compatibility
    2017-03-17 rik5 Dependencies- Depends on bugs #50007

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code