bugGNU Octave - Bugs: bug #48734, svd class - make use of implicitly...

 
 

bug #48734: svd class - make use of implicitly declared methods

Submitter:  Carnë Draug <carandraug>
Submitted:  Tue 09 Aug 2016 03:36:47 PM UTC
 
Category:  Libraries Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Tue 09 Aug 2016 08:16:15 PM UTC, comment #1: 

Just for the record, this was discussed on IRC.  There is no reason for this declaration other than being explicit that they exist. The presence of for example a copy constructor signals that it's ok to copy the object.

However, one should expect to be able to copy an object by default. It's the presence of such explicit declarations that should signal one to be careful, not the other way around. But that's dependent on each person's default. Since we are using C++11, we can make use of the "= default" notation to make it obvious.

This gets delayed for the next release and be extended to a review of all other classes for sake of consistency.

Carnë Draug <carandraug>
Project Member
Tue 09 Aug 2016 03:36:47 PM UTC, original submission:  

I may be missing something but it is there a reason for the svd class to be defining an empty destructor, default constructor, copy constructor, and copy assignment operator?

http://hg.savannah.gnu.org/hgweb/octave/file/e43199618777/liboctave/numeric/svd.h#l50

If not, I will push this https://bitbucket.org/carandraug/octave/commits/68cf459f0cea809d4582bf9b41f74aa1c3c2b4d8

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by carandraug (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.9