bugGNU Octave - Bugs: bug #48407, libinterp fails to link to libz

 
 

bug #48407: libinterp fails to link to libz

Submitted by:  Marius Schamschula <mschamschula>
Submitted on:  Tue 05 Jul 2016 12:22:14 PM UTC  
 
Category: InterpreterSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Mac OS

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 06 Jul 2016 03:00:53 PM UTC, comment #9:

For what it's worth, I pushed the fix to stable here (http://hg.savannah.gnu.org/hgweb/octave/rev/de18e547e99d). Unfortunately unless you pull from Mercurial, or jwe makes a 4.0.4 release, this isn't going to be seen by many people.

Rik <rik5>
Project Administrator
Wed 06 Jul 2016 02:30:31 PM UTC, comment #8:

The problem with "TEXI2PDF octave.pdf" was due to a bad inpolygon.pdf. After regenerating that figure, octave.pdf was generated.

Ben Abbott <bpabbott>
Project Member
Wed 06 Jul 2016 02:16:10 PM UTC, comment #7:

The ASAN problem is erratic, so by repeating "make", eventually the figures build. Unfortunately, octave.pdf does not.

I've bypassed this by "make -i dist". I'm able to build the resulting tar-ball (but still get the octave.pdf error).

Ben Abbott <bpabbott>
Project Member
Wed 06 Jul 2016 11:26:29 AM UTC, comment #6:

@Rik,

File #37727 allows the binary to be built. Unfortunately, I'm unable to build the docs due to an ASAN problem.

Ben Abbott <bpabbott>
Project Member
Wed 06 Jul 2016 04:00:38 AM UTC, comment #5:

I think that this was accidentally broken in this change made on the stable branch between 4.0.2 and 4.0.3:

http://hg.savannah.gnu.org/hgweb/octave/rev/44f7664689f2#l5.7

This is easily missed on GNU systems because libz is implicitly linked via several other system libraries.

This does not appear to be broken on the default branch, but would still appreciate some testing from someone on macOS to verify that default links liboctinterp appropriately.

Mike Miller <mtmiller>
Project Administrator
Tue 05 Jul 2016 10:16:20 PM UTC, comment #4:

As Mike said, Octave 4.2.0 is set for release in two months and it is more interesting whether we need to change anything for that release. I know when I build on Linux I have '-lz' inserted automatically.

The code on the development branch is in configure.ac which becomes configure.

As long as you have dynamic linking you should have Z_LIBS in your linking.

For stable, you can try the attached diff. But you will need to have all the development tools as it will need to rebuild the configure script. If you have it, then apply with

(file #37727)

Rik <rik5>
Project Administrator
Tue 05 Jul 2016 03:56:41 PM UTC, comment #3:

Do you have a way to test default now? That would help us release a 4.2.0 that works for MacPorts right out of the gate.

Mike Miller <mtmiller>
Project Administrator
Tue 05 Jul 2016 03:51:28 PM UTC, comment #2:

Mike,

I tried several other ways of adding -lz, but the only way I could get it to work was by patching the Makefile.in.

If 4.2.0 builds w/o any errors, this patch will be removed from the MacPorts Portfile at that time.

Marius Schamschula <mschamschula>
Tue 05 Jul 2016 03:44:24 PM UTC, comment #1:

You can work around this by running configure with LIBS=-lz instead of needing to patch the makefile.

Since 4.0.3 is likely the last 4.0.x release, this will probably not be fixed on the stable branch.

Can you test whether such a change is needed on the default branch for your build?

Mike Miller <mtmiller>
Project Administrator
Tue 05 Jul 2016 12:22:14 PM UTC, original submission:

When building octave 4.0.3 under MacPorts, the build fails, as symbols for lib are not being found. The attached patch solves this problem.

Marius Schamschula <mschamschula>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #37727:  Z_LIB.diff added by rik5 (336B - application/x-download)
file #37717:  patch-libinterp-Makefile.in.diff added by mschamschula (1KiB - application/octet-stream)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by bpabbott (Posted a comment)
  • -unavailable- added by rik5 (Updated the item)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by mschamschula (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 19 Aug 2016 03:39:21 PM UTCrik5Dependencies-=>bugs #48822 is dependent
    Wed 06 Jul 2016 03:00:53 PM UTCrik5StatusNeed Info=>Fixed
      Open/ClosedOpen=>Closed
    Wed 06 Jul 2016 11:26:29 AM UTCbpabbottCategoryConfiguration and Build System=>Interpreter
      Summarylibinterp fails to link to libz on stable (4.0.3+)=>libinterp fails to link to libz
    Wed 06 Jul 2016 04:00:38 AM UTCmtmillerCategoryInterpreter=>Configuration and Build System
      Summarylibinterp fails to link to libz=>libinterp fails to link to libz on stable (4.0.3+)
    Tue 05 Jul 2016 10:16:20 PM UTCrik5Attached File-=>Added Z_LIB.diff, #37727
    Tue 05 Jul 2016 03:44:24 PM UTCmtmillerStatusNone=>Need Info
      Release4.0.3=>dev
    Tue 05 Jul 2016 12:22:14 PM UTCmschamschulaAttached File-=>Added patch-libinterp-Makefile.in.diff, #37717

    Back to the top


    Powered by Savane 3.1-cleanup1