bugGNU Octave - Bugs: bug #48340, sighandlers.h (Octave public API...

 
 

bug #48340: sighandlers.h (Octave public API header) includes private signal-wrappers.h

Submitted by:  Robert Jenssen <morgawr>
Submitted on:  Wed 29 Jun 2016 10:55:16 AM UTC  
 
Category:  Configuration and Build System Severity:  4 - Important
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  John W. Eaton <jwe>
Originator Name:  Robert Jenssen Open/Closed:  Closed
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 07 Jul 2016 06:31:58 PM UTC, comment #5: 

I can now build the parallel package against the default branch with this change, closing as fixed.

Mike Miller <mtmiller>
Project Administrator
Thu 07 Jul 2016 06:05:49 PM UTC, comment #4: 

I think the sighnalders.h file is fixed now so that it doesn't include the signal-wrappers.h file.

John W. Eaton <jwe>
Project AdministratorIn charge of this item.
Wed 06 Jul 2016 12:26:49 PM UTC, comment #3: 

Thanks for pointing out this issue.

Cleaning up the public interfaces is still a work in progress.

I'll try to take a look at this soon.

John W. Eaton <jwe>
Project AdministratorIn charge of this item.
Wed 06 Jul 2016 07:14:56 AM UTC, comment #2: 

Updated summary and severity.

Mike Miller <mtmiller>
Project Administrator
Mon 04 Jul 2016 08:52:02 PM UTC, comment #1: 

Confirmed. Agree that it is not a bug in 'parallel', but in Octave.

'parallel' uses 'octave_child_list' and so has to include sighandlers.h. But any external code that includes this file currently won't work.

Olaf Till <i7tiol>
Project Member
Wed 29 Jun 2016 10:55:16 AM UTC, original submission:  

The parallel-3.1.0 package fails to build with the current
development octave-4.1.0+. signal-wrappers.h is not found:

$ /usr/local/dbg-octave/bin/octave-cli --eval 'pkg install parallel-3.1.0.tar.gz'
configure: WARNING: TLS disabled since symbol gnutls_srp_2048_group_prime not found in gnutls library - built with --disable-srp-authentication?
In file included from pserver.cc:28:0:
/usr/local/dbg-octave/include/octave-4.1.0+/octave/../octave/sighandlers.h:38:29: fatal error: signal-wrappers.h: No such file or directory
#include "signal-wrappers.h"
                             ^
compilation terminated.
make: *** [pserver.o] Error 1

sighandlers.h is installed in include/octave-4.1.0+/octave but signal-wrappers.h is not. The liboctave/wrappers directory is not present in the octave-4.0.2 sources. If the current source is present then a workaround is to give the include path to the source file explicitly. In my case:
CXXFLAGS="-I/usr/local/src/octave/octave/liboctave/wrappers"

Perhaps this is not a bug in the "Octave Forge Package" category but belongs in "Configuration and Build System"?

Robert Jenssen <morgawr>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by lachlan (Updated the item)
  • -email is unavailable- added by i7tiol (Posted a comment)
  • -email is unavailable- added by morgawr (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-07 mtmiller StatusConfirmed => Fixed
        Open/ClosedOpen => Closed
    2016-07-06 jwe Assigned toNone => jwe
    2016-07-06 mtmiller Severity3 - Normal => 4 - Important
        StatusNone => Confirmed
        Operating SystemGNU/Linux => Any
        Summaryparallel package fails to build with dev octave(signal-wrappers.h not found) => sighandlers.h (Octave public API header) includes private signal-wrappers.h
    2016-07-06 lachlan CategoryOctave Forge Package => Configuration and Build System

    Back to the top


    Powered by Savane 3.5