bugGNU Octave - Bugs: bug #48160, figure ignores modal and docked...

 
 

bug #48160: figure ignores modal and docked windowstyle properties

Submitted by:  John Donoghue <lostbard>
Submitted on:  Tue 07 Jun 2016 11:48:50 AM UTC  
 
Category: Plotting with OpenGLSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: John Donoghue <lostbard>
Originator Name: JohnDOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 29 Jun 2016 07:33:26 PM UTC, comment #4:

Pushed to default

http://hg.savannah.gnu.org/hgweb/octave/rev/66f3c4e81721

Mike Miller <mtmiller>
Project Administrator
Tue 28 Jun 2016 03:03:03 AM UTC, comment #3:

looks good to me

John Donoghue <lostbard>
Project MemberIn charge of this item.
Tue 28 Jun 2016 12:28:18 AM UTC, comment #2:

I applied Octave coding style to your patch, and rephrased the doc text so it reads more like the other properties (a description of the property as an object, not as an action). The patch works for me functionally. Look ready to apply?

Oh, I just noticed your email is missing from the user field in the commit message.

(file #37604)

Mike Miller <mtmiller>
Project Administrator
Fri 17 Jun 2016 05:30:16 PM UTC, comment #1:

Initial patch for Qt modals

(file #37520)

John Donoghue <lostbard>
Project MemberIn charge of this item.
Tue 07 Jun 2016 11:48:50 AM UTC, original submission:

When attempting to set the window style of a figure, if docked, or modal are set, they are silently ignored

I'm looking at the Qt tookit at the moment, and are implementing the modal property for it.

I propose showing a warning if 'docked' is set, and documenting it in the figure documentation.

John Donoghue <lostbard>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #37604:  bug-48160.diff added by mtmiller (2KiB - text/x-diff)
file #37520:  modalstyle.patch added by lostbard (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by lostbard (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 29 Jun 2016 07:33:26 PM UTCmtmillerStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Tue 28 Jun 2016 12:28:18 AM UTCmtmillerAttached File-=>Added bug-48160.diff, #37604
      CategoryPlotting=>Plotting with OpenGL
      StatusNone=>Patch Submitted
    Fri 17 Jun 2016 05:30:16 PM UTClostbardAttached File-=>Added modalstyle.patch, #37520

    Back to the top


    Powered by Savane 3.1-cleanup1