bugGNU Octave - Bugs: bug #47858, Building with hdf5-1.10 fails due...

 
 

bug #47858: Building with hdf5-1.10 fails due to changed variable type

Submitted by:  Stefan Miereis <stefanm>
Submitted on:  Thu 05 May 2016 06:43:05 PM UTC  
 
Category:  Configuration and Build System Severity:  4 - Important
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Stefan Miereis Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 02 Jul 2016 03:59:32 PM UTC, comment #5: 
John W. Eaton <jwe>
Project Administrator
Sat 02 Jul 2016 03:17:07 PM UTC, comment #4: 

Oh, I see now, the type of the function pointer that is passed to the iterate function...

I checked in the modified version of the changeset that's attached to this report, credited to Stefan.  I'll push it soon.

Thanks!

(file #37670)

John W. Eaton <jwe>
Project Administrator
Sat 02 Jul 2016 02:08:47 PM UTC, comment #3: 

It's OK to hide the hdf5_read_next data function if we never really need it apart from the iterate function, but isn't it sufficient to just change the type of octave_idf5_id to int64_t?

John W. Eaton <jwe>
Project Administrator
Thu 26 May 2016 04:36:55 PM UTC, comment #2: 

I attached a patch that introduces a wrapper function for H5Giterate called octave_H5Giterate.
The functions hdf5_read_next_data and make_valid_identifier were moved to a newly created file called oct-hdf5.cc, which also includes the new wrapper function.

(file #37281)

Stefan Miereis <stefanm>
Thu 05 May 2016 06:49:17 PM UTC, comment #1: 

Confirmed, see release notes here: https://www.hdfgroup.org/HDF5/doc/ADGuide/Changes.html

Also noting that stefanm is working on a patch for this.

Mike Miller <mtmiller>
Project Administrator
Thu 05 May 2016 06:43:05 PM UTC, original submission:  

Hdf5 changed their hid_t type from 32bit to 64 bit, now octave fails to build since octave_hdf5_id is typedef'd to an int.

Stefan Miereis <stefanm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37670:  diffs.txt added by jwe (8KiB - text/plain)
file #37281:  bug_47858.diff added by stefanm (30KiB - application/x-download)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by rik5 (Updated the item)
  • -email is unavailable- added by lachlan (Updated the item)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by stefanm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-02 rik5 StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2016-07-02 jwe Attached File- => Added diffs.txt, #37670
    2016-07-01 rik5 Severity3 - Normal => 4 - Important
    2016-06-28 lachlan StatusConfirmed => Patch Submitted
    2016-05-26 stefanm Attached File- => Added bug_47858.diff, #37281
    2016-05-05 mtmiller StatusNone => Confirmed

    Back to the top


    Powered by Savane 3.5