bugGNU Octave - Bugs: bug #47481, PKG_ADD within package inst/...

 
 

bug #47481: PKG_ADD within package inst/ directory is silently discarded

Submitter:  Carnë Draug <carandraug>
Submitted:  Mon 21 Mar 2016 03:40:01 AM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 21 Mar 2016 07:09:24 PM UTC, comment #2: 
Carnë Draug <carandraug>
Group Member
Mon 21 Mar 2016 05:52:35 PM UTC, comment #1: 

I agree this seems like a good idea. In the hg history, it can be seen that both arch-dependent and arch-independent PKG_ADD files were originally opened in "wt" mode, clobbering any file that was there before. Then a change in 2009 made the arch-dependent PKG_ADD script possible by opening it with "at". I think it makes sense to do the same for both.

Mike Miller <mtmiller>
Group Member
Mon 21 Mar 2016 03:40:01 AM UTC, original submission:  

A package cannot have a PKG_ADD file within the inst/ directory.  This is not documented anywhere, it is just accepted.  However, the inst/ directory is meant to be the directory of the package with the files ready to be installed, no build required. Indeed, the installation does copy everything within inst/.

However, a PKG_ADD file there is then removed by what I think is a bug.  When the m files are parsed for PKG_ADD directives, a file is open named like that, clobbering the previous PKG_ADD file.

By simply appending instead of writing, this supports a PKG_ADD file in a package inst/ directory.

But I may be wrong. Maybe there is a reason for why this is so? If no one opposes, I will push this.

Carnë Draug <carandraug>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #36705:  support_PKG_ADD_file_in_inst.cset added by carandraug (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by carandraug (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-03-21 carandraug StatusNone Fixed
        Open/ClosedOpen Closed
    2016-03-21 carandraug Attached File- Added support_PKG_ADD_file_in_inst.cset, #36705

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code