bugGNU Octave - Bugs: bug #47387, [octave forge] (signal) fracshift...

 
 

bug #47387: [octave forge] (signal) fracshift function ignores interpolator parameter

Submitter:  None
Submitted:  Fri 11 Mar 2016 12:18:41 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  juanpi
Originator Name:  Tim Styles Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * dev
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 20 Jan 2018 01:09:51 AM UTC, comment #2: 

This was fixed in commit 131a2629c1a6

I have added a test and demo in commit

Juan Pablo Carbajal <juanpi>
Group Member
Fri 11 Mar 2016 04:30:48 PM UTC, comment #1: 

Thanks for the report, this looks right and a very simple fix. I'll try to merge this in to the next bug fix release of the signal package.

Mike Miller <mtmiller>
Group Member
Fri 11 Mar 2016 12:18:41 PM UTC, original submission:  

I'm using the fracshift function in signal-1.2.2/fracshift.m
The help indicates that an optional third parameter can be given to specify the interpolator, but using this option has no effect.

Looking at the code in frachshift.m, line 46 is checking for a fourth parameter instead of a third parameter. Making the following change in fracshift.m causes the third parameter to be used and it works as I would expect:

46c46
<    if (nargin < 4)
---
>    if (nargin < 3)


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by juanpi (Posted a comment)
  • -email is unavailable- added by jwe (Updated the item)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 20 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-07-02 jwe Summary[octave-forge] (signal) fracshift function ignores interpolator parameter [octave forge] (signal) fracshift function ignores interpolator parameter
    2018-01-20 juanpi StatusPatch Submitted Fixed
        Assigned tomtmiller juanpi
        Open/ClosedOpen Closed
        Releaseother dev
        Operating SystemGNU/Linux Any
    2017-08-11 jwe Summary[ocave-forge] (signal) fracshift function ignores interpolator parameter [octave-forge] (signal) fracshift function ignores interpolator parameter
    2017-08-11 jwe Summarysignal package: fracshift function ignores interpolator parameter [ocave-forge] (signal) fracshift function ignores interpolator parameter
    2016-03-29 mtmiller Assigned toNone mtmiller
    2016-03-11 mtmiller StatusNone Patch Submitted
    2016-03-11 mtmiller Release3.8.1 other
        Summaryfracshift function ignores interpolator parameter signal package: fracshift function ignores interpolator parameter
    2016-03-11 rik5 Carbon-CopyRemoved 72865 -
    2016-03-11 rik5 StatusPatch Submitted None
        Releaseother 3.8.1
        Summarysignal package: fracshift function ignores interpolator parameter fracshift function ignores interpolator parameter
    2016-03-11 mtmiller CategoryOctave Function Octave Package
        StatusNone Patch Submitted
        Release3.8.1 other
        Summaryfracshift function ignores interpolator parameter signal package: fracshift function ignores interpolator parameter

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code