bugGNU Octave - Bugs: bug #46723, Resize close and dock butons on Mac

 
 

bug #46723: Resize close and dock butons on Mac

Submitted by:  Sebastian <sschoeps>
Submitted on:  Sat 19 Dec 2015 11:06:08 PM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Sebastian Open/Closed:  Closed
Release:  dev Operating System:  Mac OS

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 17 Aug 2018 09:35:57 PM UTC, comment #11: 

Yes, the issue is fixed. Thanks! Please close it.

Sebastian <sschoeps>
Wed 15 Aug 2018 06:12:39 PM UTC, comment #10: 

@Sebastian: This bug is from 2016.  Are button sizes still a problem on Macs?

Rik <rik5>
Project Administrator
Sun 14 Aug 2016 11:08:41 AM UTC, comment #9: 

Added a new patch "macosx_iconsize_qt5". I am unsure how device dependent this is. Maybe someone can check if this works on windows and linux, too?

(file #38206)

Sebastian <sschoeps>
Sun 14 Aug 2016 07:39:41 AM UTC, comment #8: 

Octave compiles now with qt5. Can a qt expert help me to fix this?

Sebastian

Sebastian <sschoeps>
Sat 02 Jul 2016 01:57:18 AM UTC, comment #7: 

Retagging "In progress".

Lachlan Andrew <lachlan>
Tue 22 Dec 2015 02:41:06 PM UTC, comment #6: 

For Qt5 refer to bug #40252. (No, the default branch does not compile with Qt5 yet).

Mike Miller <mtmiller>
Project Administrator
Tue 22 Dec 2015 10:15:22 AM UTC, comment #5: 

Sebastian: Fedora 23 is at qt5. But ./configure
chooses qt4.

Michael Godfrey <godfrey>
Project Member
Tue 22 Dec 2015 09:58:11 AM UTC, comment #4: 

Your patch seems to change nothing. See image attached.

I believe that we might need to rescale due to high resolution (on the mac it is called "retina").  In qt5 we could do rescaling with "devicePixelRatio" but this seems to be not available in qt4.

BTW: can octave be compiled with qt5?


Sebastian <sschoeps>
Tue 22 Dec 2015 07:15:23 AM UTC, comment #3: 

It seems that Qt uses a style with larger icons for the dock-widget compared to the main-window. The toolbar icons have correct size, the close/dock buttons not, both are based on Qt::PM_SmallIconSize from the related style. The larger style in the widgets are also reflected by the quite large folder icons in the file browser.

Could you please try the attached patch that uses the style from the main-window for the close/dock buttons of the widgets?

(file #35831)

Torsten Lilge <ttl>
Project Member
Mon 21 Dec 2015 10:25:51 AM UTC, comment #2: 

The easy part: the screenshot that you were linking to uses icon size "normal". While the attached ones use size "small". However, this does not affect the close or undock buttons. I added a new attachment to make the difference clear.

The difficult part: my patch does not help. The problem of the huge buttons only occurs on the retina display (https://en.wikipedia.org/wiki/Retina_Display). If I attach an external screen with normal resolution to my Macbook and I open octave on that screen then everything is as expected. This explains the differences in the screenshots that you observed (the screenshot in my blog was made on a regular screen).

I guess nobody here has experience with issues like this?


Sebastian <sschoeps>
Sun 20 Dec 2015 12:04:36 PM UTC, comment #1: 

Thank you for the report and the patch. Feedback on the appearance of the gui on different systems is highly welcome.

Concerning the screenshot: Is your screenshot at
http://www.schoeps.org/home/wp-content/uploads/2015/12/octave41mac.png
with or without the patch? It seems to me that the dock/close icons have a size that differs from both sizes in the attached patch. Not related to this bug: Do you know what icon size was selected in the preferences for the screenshots?

Torsten Lilge <ttl>
Project Member
Sat 19 Dec 2015 11:06:08 PM UTC, original submission:  

Probably the Mac GUI should be resigned by an expert, however, for now, please apply the attached patch to rescale the dock bar icons appropriately.

Sebastian <sschoeps>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #38206:  macosx_iconsize_qt5.patch added by sschoeps (881B - application/octet-stream - patch using qt5's devicePixelRatio)
file #35811:  icon_sizes.png added by sschoeps (113KiB - image/png)
file #35801:  Screenshots.png added by sschoeps (280KiB - image/png)
file #35802:  macosx_iconsize.patch added by sschoeps (637B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by lachlan (Posted a comment)
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by godfrey (Posted a comment)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by sschoeps (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-08-17 mtmiller Carbon-CopyRemoved 80942 => -
    2018-08-17 mtmiller StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
    2016-08-14 sschoeps Attached File- => Added macosx_iconsize_qt5.patch, #38206
    2016-07-02 lachlan StatusPatch Submitted => In Progress
    2016-01-04 siko1056 StatusNone => Patch Submitted
    2015-12-22 sschoeps Attached File- => Added patch_bug46723_main-win_style.png, #35834
    2015-12-22 ttl Attached File- => Added bug46723_main-win_style.patch, #35831
    2015-12-21 sschoeps Attached File- => Added icon_sizes.png, #35811
    2015-12-19 sschoeps Attached File- => Added Screenshots.png, #35801
        Attached File- => Added macosx_iconsize.patch, #35802

    Back to the top


    Powered by Savane 3.5