bugGNU Octave - Bugs: bug #46332, Make video package compile with...

 
 

bug #46332: Make video package compile with Octave 4.0.0

Submitted by:  PrasannaKumar Muralidharan <prasannatsm>
Submitted on:  Fri 30 Oct 2015 07:28:07 AM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  other Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 02 Nov 2015 10:47:03 AM UTC, comment #5: 

I have created a new patch and have put it in the patch tracker (https://savannah.gnu.org/patch/index.php?8786).

This bug can be closed.

PrasannaKumar Muralidharan <prasannatsm>
Sat 31 Oct 2015 01:29:20 PM UTC, comment #4: 

As suggested I will make changes so that the code works with current stable release of Octave.

Will put the patch on patch tracker on Monday.

PrasannaKumar Muralidharan <prasannatsm>
Fri 30 Oct 2015 12:01:18 PM UTC, comment #3: 

Please also put on patch tracker, let's follow up there.

Just two remarks:

AFAIK it is possible to check for Octave version in code, possibly even in #define statements (I'm unsure there). See HACKING.

But I think it preferable, in the sense of less complications and less work, to aim at supporting only Octave's development + current stable releases and at the very most the previous stable release both when creating a new OF package and when resurrecting an old and abandoned one from the code graveyards.
After all, core Octave itself only receives patches for the stable and development branches - backports aren't supported.
It'll make your life as package maintainer significantly lighter :-)

Philip Nienhuis <philipnienhuis>
Project Member
Fri 30 Oct 2015 11:28:07 AM UTC, comment #2: 

I assume that older versions of Octave would need those macros. If that is not the case I can remove the lines and create a new changeset.

I think users with older versions of Octave will get a chance to use this package without updating.

PrasannaKumar Muralidharan <prasannatsm>
Fri 30 Oct 2015 11:11:19 AM UTC, comment #1: 

IMHO, the correct fix (also for Octave 3.8.2) would be to just remove the lines DEFINE_OCTAVE_ALLOCATOR(Avifile) and DECLARE_OCTAVE_ALLOCATOR

Can you create a new changeset and add it to the patch tracker?

Thanks for contributing, Andy

Andreas Weber <andy1978>
Project Member
Fri 30 Oct 2015 07:28:07 AM UTC, original submission:  

Octave forge video package does not compile with Octave 4.0.0 and above. Attached a patch to fix this.

PrasannaKumar Muralidharan <prasannatsm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #35332:  compile_with_octave_4.0.0+.diff added by prasannatsm (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by prasannatsm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-11-02 philipnienhuis Open/ClosedOpen => Closed
    2015-10-30 prasannatsm Attached File- => Added compile_with_octave_4.0.0+.diff, #35332

    Back to the top


    Powered by Savane 3.5