bugGNU Octave - Bugs: bug #46236, GUI Workspace - use same column...

 
 

bug #46236: GUI Workspace - use same column headings as Matlab

Submitted by:  Ceral Paquet <octavebugs>
Submitted on:  Sat 17 Oct 2015 01:11:32 PM UTC  
 
Category:  GUI Severity:  2 - Minor
Priority:  3 - Low Item Group:  Matlab Compatibility
Status:  Patch Submitted Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sat 23 Jul 2016 02:07:46 PM UTC, comment #7: 

I don't see the failure in the Array.cc tests.

I also updated the patch with some style fixes (eliminate TAB characters, fix some whitespace, etc.) and simply set the fields to "" if the maximum number of elements to compute statistics is 0.

If you continue to work on this, please use the updated patch.

But in any case, this approach is too slow.  Something needs to be done to limit repeated computation.  For example, try the following:

for i = 1:1000, eval (sprintf ("x%i = rand (1000, 1);", i)); end

and then try to do anything at the command prompt.  I see a several second delay each time the prompt is displayed as the values for the workspace widget are recomputed.

(file #37997)

John W. Eaton <jwe>
Project Administrator
Sun 03 Jul 2016 08:01:08 PM UTC, comment #6: 

Philip, thanks for your feedback, I will take a look at the problem.

Stefan Miereis <stefanm>
Sun 03 Jul 2016 09:38:25 AM UTC, comment #5: 

With recent dev Octave, after applying this patch to a "clean" octave-4.1.0+ source tree + building, "make check"gives:

Integrated test scripts:

  liboctave/array/Array.cc-tst ................................median: X cannot be an empty matrix

Backing out this cs makes "make check" work again.

I'm no C++ expert, but I suspect the symtab changes may be the cause, as there seems to be a mix-up of functions and references to it.
While debugging e.g., "test strread" (or any other .m function) a warning in mean and an error in median is given with a backtrace to test.m at L.601 col. 9 where neither mean nor median aren't even called.

Stefan, could you please fix the issue and supply a new patch?

I often had this mod in my builds (I make windows builds & install them at work about every week) but didn't note that the test() command was affected by it. Yet IMO your mod is a useful addition to the Octave GUI.

Philip Nienhuis <philipnienhuis>
Project Member
Fri 01 Jul 2016 04:52:04 PM UTC, comment #4: 

Here's an update cset that applies cleanly to current dev branch. I did my best to keep the original credits and commit message.

I've been using it for several months (on Windows), not often, but AFAICS it works well.

(file #37654)

Philip Nienhuis <philipnienhuis>
Project Member
Fri 27 Nov 2015 11:56:53 PM UTC, comment #3: 

I modified the patch to bring the commit message more in line with the gnu standards.

(file #35582)

Stefan Miereis <stefanm>
Thu 12 Nov 2015 06:44:07 PM UTC, comment #2: 

I wrote a patch that adds the desired columns to the workspace. The statistical data are only computed for arrays below a certain size, which I initially set to 10^6 elements, but the threshold can be changed in Edit->preferences->workspace. For larger arrays it simply shows "<too many elements>", like in matlab.
I tried to make it so that only the statistics for the currently displayed columns are calculated, but I couldn't figure out how to do that without changing too much. I also moved the attribute column into the Class field, as suggested.

(file #35443)

Stefan Miereis <stefanm>
Sun 18 Oct 2015 03:10:36 PM UTC, comment #1: 

So any additional type info should be included in the Class field (in parens) instead of in a separate column.  OK, that seems like a reasonable change.

If the simple stats about a numeric value need to be computed for the variable display, I suppose we should think about caching that info along with the numerical data so we don't compute it many times unnecessarily.

John W. Eaton <jwe>
Project Administrator
Sat 17 Oct 2015 01:11:32 PM UTC, original submission:  

This is more or less a bump of #44056 (https://savannah.gnu.org/bugs/?func=detailitem&item_id=44056) to add more columns to the workspace GUI and let users hide/show specific columns in Preferences.

Matlab has the following:

Name
Value
Size
Bytes
Class
Min
Max
Range
Mean
Median
Mode
Var
Std

whereas Octave has:

Name
Class
Dimension
Value
Attribute

If I create A = sparse(1,1,i) then in Matlab the Value is 0+1i and the Class is double (sparse complex). In Octave the same variable has Value ..., Class double and Attribute complex. The latter heading is not present in Matlab.

Ceral Paquet <octavebugs>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37997:  bug_46236_workspace_colheaders_v3.cset added by jwe (24KiB - application/octet-stream)
file #37654:  bug_46236_workspace_colheaders_v2.cset added by philipnienhuis (24KiB - application/octet-stream)
file #35582:  bug_46236.diff added by stefanm (24KiB - application/x-download)
file #35443:  bug_46236.diff added by stefanm (23KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by stefanm (Updated the item)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by octavebugs (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-23 jwe Attached File- => Added bug_46236_workspace_colheaders_v3.cset, #37997
    2016-07-01 philipnienhuis Attached File- => Added bug_46236_workspace_colheaders_v2.cset, #37654
        Release4.0.0 => dev
        Operating SystemGNU/Linux => Any
    2015-12-22 mtmiller CategoryNone => GUI
        Severity3 - Normal => 2 - Minor
        Priority5 - Normal => 3 - Low
        Item GroupNone => Matlab Compatibility
        StatusNone => Patch Submitted
    2015-11-27 stefanm Attached File- => Added bug_46236.diff, #35582
    2015-11-12 stefanm Attached File- => Added bug_46236.diff, #35443

    Back to the top


    Powered by Savane 3.5