bugGNU Octave - Bugs: bug #44686, Behaviour of figure property...

 
 

bug #44686: Behaviour of figure property 'ToolBar' when set to 'auto'

Submitter:  Guillaume <gyom>
Submitted:  Wed 01 Apr 2015 12:20:51 PM UTC
   
 
Category:  Plotting Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Guillaume Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 02 Apr 2015 12:21:54 PM UTC, comment #5: 

You are right - "hg update" twice fixed it.

Many thanks for your help.

Guillaume <gyom>
Thu 02 Apr 2015 11:36:44 AM UTC, comment #4: 

I saw a strange behavior on my machine when applying the patch. I had to update twice after pull: may have something to do with "tip" and bookmark "@" that are currently not the same in the repo while they are on my machine.
Can you try to "hg update" again? How does libgui/graphics/Figure.cc look like at line 133: modified or old version (see http://hg.savannah.gnu.org/hgweb/octave/rev/08fae2e963fb)?

Pantxo Diribarne <pantxo>
Group Member
Thu 02 Apr 2015 11:17:00 AM UTC, comment #3: 

Thanks. It still doesn't work for me though and I observe the same things than Rik, after recompilation.

Guillaume <gyom>
Wed 01 Apr 2015 09:31:48 PM UTC, comment #2: 

I pushed a simple patch that fixes the toolbar and menubar interaction at initialization:

http://hg.savannah.gnu.org/hgweb/octave/rev/08fae2e963fb

Closing bug report.

Pantxo Diribarne <pantxo>
Group Member
Wed 01 Apr 2015 03:59:11 PM UTC, comment #1: 

There is an order of execution issue or race condition going on.  The code works if the figure has been created first.


hf = figure ();
set (hf, "menubar", "none");


But doesn't work if the figure property is set at the time of figure creation.


figure ("menubar", "none");


I'm adding Pantxo to the CC list since he just recently coded this and can probably tell what the problem is quickly.

Rik <rik5>
Group administrator
Wed 01 Apr 2015 12:20:51 PM UTC, original submission:  

When 'ToolBar' is set to 'auto' (default), it should use the same value as the 'MenuBar' property but, if 'MenuBar' is set to 'none', the toolbar is still displayed (with Qt):


figure('MenuBar','none');


Guillaume <gyom>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by rik5
  • -email is unavailable- added by gyom (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-04-01 pantxo StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2015-04-01 rik5 StatusNone Confirmed
    2015-04-01 rik5 Carbon-Copy- Added pantxo

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code