bugGNU Octave - Bugs: bug #44359, Save and restore user FFLAGS, add...

 
 

bug #44359: Save and restore user FFLAGS, add additional options to AM_FFLAGS

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Tue 24 Feb 2015 03:09:49 AM UTC  
 
Category: Configuration and Build SystemSeverity: 2 - Minor
Priority: 5 - NormalItem Group: Feature Request
Status: PostponedAssigned to: None
Originator Name: Open/Closed: Open
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 07 Sep 2017 09:26:56 PM UTC, comment #4:

I think it is, pending resolution of bug #50339. My hope was if the user wants to build with FFLAGS="-g", and configure decides that it needs to add -fdefault-integer-8, then there should be a separate XTRA_FFLAGS variable with -fdefault-integer-8 and FFLAGS should be just -g.

Mike Miller <mtmiller>
Project Administrator
Fri 01 Sep 2017 07:28:07 PM UTC, comment #3:

Is this bug still relevant? configure.ac has been changed quite a bit since Feb. 2015.

Rik <rik5>
Project Administrator
Tue 24 Feb 2015 04:53:07 AM UTC, comment #2:

Sounds good, and this is working for me. Updating the title and marking postponed to work on later.

Mike Miller <mtmiller>
Project Administrator
Tue 24 Feb 2015 04:08:08 AM UTC, comment #1:

For now, I just did this:

http://hg.savannah.gnu.org/hgweb/octave/rev/4006a7377a19

It seems complicated by the fact that we might need to add more than one or two things to FFLAGS to get tests to succeed if we have to link with BLAS libraries and we need -fdefault-integer-8 or -ff2c. It seems easier for now to just not save and restore FFLAGS. Maybe later we can revisit this problem.

John W. Eaton <jwe>
Project Administrator
Tue 24 Feb 2015 03:09:49 AM UTC, original submission:

The changes to save and restore the user compiler flags aren't working quite right with FFLAGS.

One problem is that FFLAGS is saved way too early, before the defaults are set and the compiler detected. If FFLAGS is not given to configure by the user, it will always be empty.

Another problem is that there is no XTRA_FFLAGS. A few flags may have been added to FFLAGS in previous versions of Octave, such as -mieee or -ff2c. I think these will now be discarded at the end of configure. It might not be too hard to introduce an XTRA_FFLAGS variable to handle these for the liboctave directory.

I'll take a look at this if jwe or rik don't beat me too it.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  • -unavailable- added by mtmiller
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 07 Sep 2017 09:27:12 PM UTCmtmillerDependencies-=>Depends on bugs #50339
    Tue 24 Feb 2015 04:53:07 AM UTCmtmillerSeverity4 - Important=>2 - Minor
      Item GroupRegression=>Feature Request
      StatusNone=>Postponed
      SummaryFFLAGS not set correctly now=>Save and restore user FFLAGS, add additional options to AM_FFLAGS
    Tue 24 Feb 2015 03:09:50 AM UTCmtmillerCarbon-Copy-=>Added jwe

    Back to the top


    Powered by Savane 3.1-cleanup1