bugGNU Octave - Bugs: bug #44324, Support of "close all...

 
 

bug #44324: Support of "close all force"

Submitter:  Guillaume <gyom>
Submitted:  Fri 20 Feb 2015 03:54:13 PM UTC
   
 
Category:  Plotting Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Matlab Compatibility
Status:  Fixed Assigned to:  None
Originator Name:  Guillaume Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 30 Apr 2015 01:42:18 PM UTC, comment #5: 

Aah, yes.  I looked only briefly and saw that the change was small and for Matlab Compatibility which is insufficient justification for putting it on the release branch at this late a date.  But if it is a regression then a change is warranted.  I grafted the change on to the stable (release) branch here (http://hg.savannah.gnu.org/hgweb/octave/rev/f8d443fe0de3).

Rik <rik5>
Group administrator
Thu 30 Apr 2015 10:21:11 AM UTC, comment #4: 

Thanks, Rik.

Maybe I shouldn't have mentioned MATLAB compatibility as it is also a regression from previous Octave versions and a behavior you would expect, eg with the construct:


close(findobj('type','figure','tag','xx'))


A comment in the code seems to refer to this:


## 2010-05-02   PBig    allow empty argument


Given this and the fact it's a small and 'safe' patch, any chance it could make it into the stable branch?

Guillaume <gyom>
Thu 30 Apr 2015 12:12:46 AM UTC, comment #3: 

I made the change for Matlab compatability on the dev branch here (http://hg.savannah.gnu.org/hgweb/octave/rev/3797df921988).

Rik <rik5>
Group administrator
Wed 29 Apr 2015 06:18:48 PM UTC, comment #2: 

Just noticed that:


close([])


should return without error for MATLAB compatibility.

Tiny patch attached that fixes it.

(file #33838)

Guillaume <gyom>
Wed 22 Apr 2015 03:45:57 PM UTC, comment #1: 

I used your patch as a template and added support for the "force" argument to close.  I also redid the docstring and applied stricter input validation.  See (http://hg.savannah.gnu.org/hgweb/octave/rev/7e0e8fb16201).  Closing report.

Rik <rik5>
Group administrator
Fri 20 Feb 2015 03:54:13 PM UTC, original submission:  

The attached file adds support of "force" option to close():
  http://mathworks.com/help/matlab/ref/close.html
It also conforms to MATLAB behavior that figure handles can be used instead of keyword 'all' in conjunction with options "hidden" and "force".

Guillaume <gyom>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #33838:  empty_close.diff added by gyom (445B - text/x-patch)
file #33139:  close_force.diff added by gyom (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by gyom (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-04-29 gyom Attached File- Added empty_close.diff, #33838
    2015-04-22 rik5 StatusNone Fixed
        Open/ClosedOpen Closed
    2015-02-20 gyom Attached File- Added close_force.diff, #33139

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code