bugGNU Octave - Bugs: bug #44303, resolve duplication / merge...

 
 

bug #44303: resolve duplication / merge runtests and __run_test_suite__

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Thu 19 Feb 2015 05:13:06 AM UTC  
 
Category: Octave FunctionSeverity: 2 - Minor
Priority: 5 - NormalItem Group: Feature Request
Status: NoneAssigned to: None
Originator Name: Open/Closed: Open
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 20 Feb 2015 01:04:06 AM UTC, comment #4:

Re: Comment #2. In my second start-up, back when I was in my 20's and perhaps less politic than I am now, I got the nickname of the "bulldozer". Mostly in a good way because I just rolled over whatever obstacles there were. Octave is meant to be a fun coding project so don't let me stop you enjoying this bug report. I mostly figure that no one else wants the job of being release manager and herding all of the cats.

Rik <rik5>
Project Administrator
Thu 19 Feb 2015 09:44:12 PM UTC, comment #3:

My main purpose is to have a documented callable function that users should be using to run test code in a given directory or in the entire load path. And ideally, the way tests are run and the output to the screen would be the same as `make check`.

People testing mxe-octave seem to have picked up on using _run_test_suite_, but it has no help, no options, always creates the same log file, several problems as a result of it really being meant for internal consumption only. But it is used more, so it does have more and better features than runtests (e.g. operating on *-tst files).

Don't let this hold up the release though :)

Mike Miller <mtmiller>
Project Administrator
Thu 19 Feb 2015 06:05:22 PM UTC, comment #2:

Rik:

Yeah, but this is the kind of distracting challenge that I like, so maybe I will waste some time on it... :-)

John W. Eaton <jwe>
Project Administrator
Thu 19 Feb 2015 05:39:58 PM UTC, comment #1:

This is explained by parallel evolution. runtests() evolved with rundemos() as a convenient way to check everything in a directory.

_run_test_suite_ evolved out of 'make check', in particular how to get the equivalent of 'make check' on an installed Windows system.

It may be harder than it looks to merge the two together since they were built differently.

Rik <rik5>
Project Administrator
Thu 19 Feb 2015 05:13:06 AM UTC, original submission:

There is a lot of duplicated functionality between the runtests.m and _run_test_suite_.m function files. Both functions have equivalent code to find files with unit tests, recurse into subdirectories, and display test results in a formatted output to the screen.

The _run_test_suite_ function primarily exists to support the fntests.m script used by `make check`. But it can also be used to run the full test suite on an installed copy of Octave. It also creates the fntests.log file.

The runtests function is more useful for testing functions in packages or in arbitrary directories on the load path. The output is slightly different from _run_test_suite_, and no log file is written.

It would be preferable to merge these functions or at least factor out as much common code as possible.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item

    Back to the top


    Powered by Savane 3.1-cleanup1