bugGNU Octave - Bugs: bug #44060, audiodevinfo fails to build on...

 
 

bug #44060: audiodevinfo fails to build on updated fedora 20

Submitted by:  John Donoghue <lostbard>
Submitted on:  Wed 21 Jan 2015 03:59:53 PM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: None
Originator Name: JohnDOpen/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 05 Feb 2015 01:29:56 AM UTC, comment #8:

@Mike: Your analysis seems correct. Closing report.

Rik <rik5>
Project Administrator
Wed 04 Feb 2015 06:28:59 AM UTC, comment #7:

I think bug #36064 is no longer relevant actually.

If you look at when that bug was reported and reproducible, Octave 3.6.2 used to include $(CPPFLAGS) in $(AM_CPPFLAGS). So the flags order used to be

So the original error in that bug report was because of $(CPPFLAGS) appearing ahead of $(MAGICK_CPPFLAGS). I think that actually may have been fixed with http://hg.savannah.gnu.org/hgweb/octave/rev/9db33c1f6f5f.

Not saying I'm not missing anything or there aren't some complicated cases where the order is still wrong, but I don't think the current order breaks bug #36064.

Mike Miller <mtmiller>
Project Administrator
Mon 02 Feb 2015 05:27:39 AM UTC, comment #6:

Re-opening bug as the fix breaks bug #36064.

See the reasoning in that report for why user specific CPPFLAGS should precede generic CPPFLAGS, as opposed to the CFLAGS variable where the user's options should always be last.

Rik <rik5>
Project Administrator
Wed 21 Jan 2015 11:07:43 PM UTC, comment #5:

What about bug #36064?

See this cset

Rik <rik5>
Project Administrator
Wed 21 Jan 2015 05:20:20 PM UTC, comment #4:

I checked in the following change

http://hg.savannah.gnu.org/hgweb/octave/rev/228cfaf24208

John W. Eaton <jwe>
Project Administrator
Wed 21 Jan 2015 05:02:36 PM UTC, comment #3:

That makes more sense to me

John Donoghue <lostbard>
Project Member
Wed 21 Jan 2015 04:59:47 PM UTC, comment #2:

Hmm, I think issues like this could cause us some trouble in the future if there is a header file name conflict and we actually need both files to be included.

In any case, should we maybe make a change that is uniform for all the DLD files? The attached change would also make the order of CPPFLAGS more consistent with what we do for other special cases, where I see the individual CPPFLAGS variables for dependencies appearing after AM_CPPFLAGS.

(file #32891)

John W. Eaton <jwe>
Project Administrator
Wed 21 Jan 2015 04:02:23 PM UTC, comment #1:

Patch attached

(file #32887)

John Donoghue <lostbard>
Project Member
Wed 21 Jan 2015 03:59:53 PM UTC, original submission:

On a recent update of my fedora box, octave suddently started to fail building audiodevinfo.

portaudio-19-17, alsa-lib-devel-1.0.27.2-2.

Error as below:

It appears to be pulling error.h from alsa instead of the system error.h.
Modifying the flags to include AM_CPPFLAGS before the PORT_AUDIO_CPPFLAGS makes it work again.

John Donoghue <lostbard>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #32891:  diffs.txt added by jwe (571B - text/plain)
file #32887:  audioflags.patch added by lostbard (903B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by jwe (Updated the item)
  • -unavailable- added by lostbard (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 05 Feb 2015 01:29:56 AM UTCrik5Open/ClosedOpen=>Closed
    Mon 02 Feb 2015 05:27:38 AM UTCrik5Open/ClosedClosed=>Open
    Wed 21 Jan 2015 05:20:20 PM UTCjweStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Wed 21 Jan 2015 04:59:47 PM UTCjweAttached File-=>Added diffs.txt, #32891
    Wed 21 Jan 2015 04:02:23 PM UTClostbardAttached File-=>Added audioflags.patch, #32887
      StatusNone=>Patch Submitted

    Back to the top


    Powered by Savane 3.1-cleanup1