Add a New Comment (Rich Markup)
Comment Type & Canned Response: None None > Multiple Canned Responses Fixed in development Crash with no stack trace Already fixed in newer version Fixed in stable Bad description Bad description and crash Bad stack trace Obsolete version Duplicate and not fixed Duplicate and needs more info Duplicate and fixed Need info and old
David, do you plan to respond to Rik's request?
Also, what is the main benefit of your patch? Is it smaller code, faster execution, easier maintenance or just the elegance of having a common template?
You note that min() isn't in the code; the code uses std::min in some places.
It would be nice for each function or template to have a brief comment explaining why it exists. Most are so simple that the reader can see what and how, but it is useful to describe why -- what does the function enable?
Have you looked at the Matlab find function (http://www.mathworks.com/help/matlab/ref/find.html)? There is no 4th argument and Octave is extremely unlikely to break compatibility with such a core function.
I think it would be better to submit a changeset for just the template changes.
I cleaned up the "find" function adding templates to channel all calls to 'find' for all types into the same template function.
As a side-effect, this fixes the following matlab/full-matrix incompatibility: octave:3> a = sparse(0,0); octave:4> size(find(a)) ans =
0 1
(Matlab and full matrices give 0 0)
Additionally I added a fourth parameter to specify the desired dimension of the output vectors: octave:3> a = eye(3); octave:4> [i,j,v] = find(a,Inf,"first",2) i =
1 2 3
j =
v =
1 1 1
Could someone please look over my changes?
Thanks
(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)
Attach Files: Comment:
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Only project members can vote.
Please enter the title of George Orwell's famous dystopian book (it's a date):
Follow 3 latest changes.
Copyright © 2022 Free Software Foundation, Inc. Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved. The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team. Source Code
Powered by Savane 3.9