bugGNU Octave - Bugs: bug #41260, regression in urlread: second...

 
 

bug #41260: regression in urlread: second return value may be undefined

Submitted by:  Julien Bect <jbect>
Submitted on:  Fri 17 Jan 2014 09:17:41 AM UTC  
 
Category: Octave FunctionSeverity: 4 - Important
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: 3.8.0Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 22 Jan 2014 06:39:28 PM UTC, comment #6:

I tested and checked in the changes (http://hg.savannah.gnu.org/hgweb/octave/rev/b522d04382cf). Closing report.

Rik <rik5>
Project Administrator
Wed 22 Jan 2014 08:09:41 AM UTC, comment #5:

It looks to me like the attached patch should fix it. If you agree, apply it. I don't need to be credited.

(file #30336)

John W. Eaton <jwe>
Project Administrator
Fri 17 Jan 2014 05:21:16 PM UTC, comment #4:

The problem bit of code is this section at line 557 of urlwrite.cc:

As you can see, if the curl call fails retval is not assigned to which leaves missing values for the second and third return arguments. It looks pretty easy to fix, but I'm going to just add jwe to the CC list since he was the one who was changing this code back in October.

Rik <rik5>
Project Administrator
Fri 17 Jan 2014 04:48:15 PM UTC, comment #3:

Thanks, retitling and recategorizing to reflect that.

Mike Miller <mtmiller>
Project Administrator
Fri 17 Jan 2014 03:45:55 PM UTC, comment #2:

You're right, it seems like a regression in urlread ().

Julien Bect <jbect>
Fri 17 Jan 2014 02:18:47 PM UTC, comment #1:

This actually looks like a regression in the urlread function. If you agree with my diagnosis I'd rather retitle this bug to reflect that. The pkg function is using urlread and expecting it to return two return values. Observe in octave 3.6.4

while in 3.8.0

If this is fixed, then you'll get this error message from pkg, which I do get in 3.6.4:

Mike Miller <mtmiller>
Project Administrator
Fri 17 Jan 2014 09:17:41 AM UTC, original submission:

If I type the following:

I get:

Of course, the problem is that I mistyped the package name, but the error message could certainly be a little clearer :)

Julien Bect <jbect>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30336:  diffs.txt added by jwe (786B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Updated the item)
  • -unavailable- added by rik5
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by jbect (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 22 Jan 2014 06:39:28 PM UTCrik5StatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Wed 22 Jan 2014 08:09:41 AM UTCjweAttached File-=>Added diffs.txt, #30336
    Fri 17 Jan 2014 05:21:30 PM UTCrik5Carbon-Copy-=>Added jwe
    Fri 17 Jan 2014 04:48:15 PM UTCmtmillerSeverity3 - Normal=>4 - Important
      Item GroupIncorrect Result=>Regression
      StatusNeed Info=>Confirmed
      Summarypkg should issue a clearer error message when the requested package is not found=>regression in urlread: second return value may be undefined
    Fri 17 Jan 2014 02:18:47 PM UTCmtmillerItem GroupOther=>Incorrect Result
      StatusNone=>Need Info

    Back to the top


    Powered by Savane 3.1-cleanup1