bugGNU Octave - Bugs: bug #39553, geometry package: missing...

 
 

bug #39553: geometry package: missing planePoint

Submitted by:  None
Submitted on:  Mon 22 Jul 2013 08:20:31 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Alex Burka Originator Email:  -email is unavailable-
Open/Closed:  Closed Release:  3.6.4
Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Wed 16 Nov 2016 10:10:03 PM UTC, comment #10: 

Closing this bug as fixed, the geometry package has the planePoint function now.

Mike Miller <mtmiller>
Project Administrator
Sat 27 Jul 2013 08:53:02 PM UTC, comment #9: 

Hi Alex,

To test your changes you have to run octave on the folder of the package (where you see the script PKG_ADD) and then

PKG_ADD

or

source PKG_ADD

You should get a message saying that the package was load for testing.
If this doesn't work try

pkg uninstall geometry

and then again the previous commands

Yes, automatic broadcasting produces warnings. The user can deactivate those by running
warning("off","Octave:broadcast");

So it is left for them to decide. One could go to all the functions and add a line
warning("off","Octave:broadcast","local");
but since automatic broadcasting will become the standard and not the exception that seems a waste of time.

If you plan to stay with us for a while, send an email to the maintainers list asking for push permission to OF. Otherwise use the patch tracker to upload your ported functions or diffs files.

Eventually we will move geometry to mercurial so this will become handy
http://wiki.octave.org/Mercurial_(hg)_cheat_sheet#Creating_changesets_with_hg

Cheers

 
Juan Pablo Carbajal <juanpi>
Project Member
Sat 27 Jul 2013 02:56:44 AM UTC, comment #8: 

Thanks Juan. Could I bother you to walk me through a few things? (I have never contributed to Octave before.) Let's say I were to port linePosition3d and drawPlane3d (which I did, though with an ugly hack around an apparent bug in patch). When I start Octave in the directory with my checkout, of course I can load the new functions, but other Octave instances are still pointing at the 'geometry' installed by 'pkg install -forge'. So, how exactly do you test? You mentioned PKG_ADD but I can't figure out how to use it. Also, I assume that I don't have commit access, so what should I do with the ported functions? Do I just post patches to the bug tracker?

Second, using automatic broadcasting throws a warning, every time. This seems like it will confuse users, because they didn't write the code which uses broadcasting. Is it customary to turn off the warning for library functions like these?

Thanks!
Alex

Alex Burka <aburka>
Tue 23 Jul 2013 07:44:08 PM UTC, comment #7: 

Hi

That's great. I just checked and I had already added all the functions to /main/geomtry/devel

I have just ported planePoint.m. you may want to follow that as an example. I have removed the use of repmat in favor of automatic broadcasting. This, of course, is not needed every time, I was just in the mood. You can find it in the repository.

Also, if you port a function, do not forget to add your name to the copyright and the author list. In case I disappear and somebody needs help.

Do not forget, to add the function to the INDEX (in the corresponding place, I am ordering alphabetically) and the name of the function to the NEWS file.

There is also some work, not in porting functions (be warned, it is quite tedious), but in porting and updating the tests and demos in the "Demos" and "Test" subfolders inside the devel folder.

Trick: To test your canges and ports, you do can test the repository version of geometry (before releasing it) by running the PKG_ADD script directly from the Octave interpreter. This saves a lot of time.

Cheers

Juan Pablo Carbajal <juanpi>
Project Member
Tue 23 Jul 2013 07:28:38 PM UTC, comment #6: 

Sure, I'll help.

Alex Burka <aburka>
Tue 23 Jul 2013 07:10:20 PM UTC, comment #5: 

Hi,

Matgeom wont work in Octave. It uses many function from toolboxes (that we have under different names or just do not have) and I am adapting/removing as I do the port.

Also, though Octave tries to be 100% matlab compatible, demos and test are not done the matlab way (which is horrible)  and therefore somebody installing matgeom into Octave will not have demos.

Further, the help is in matlb stlye. I was porting this into texinfo, but I think I wont do it anymore (takes too much time).

Finally, David Legland (developer of matgeom) is not supporting it anymore and as the packages says Octave geometry already extends it with several functions (all io functions, all piece-wise polynomial polygons, grpah functions, and some other specific functions). David, though he will like it, wont add those to MatGeom.

So Alex, would it be possible to have you as a porter of Matgeom into geometry? I can upload the files to the dev folder and you can help with the porting. If you can't then please have some patience till I upload the rest of the functions.

Cheers

Juan Pablo Carbajal <juanpi>
Project Member
Tue 23 Jul 2013 03:28:30 PM UTC, comment #4: 

I have added the email of the geometry maintainer to the CC list of this bug.

The geometry package includes more than one package into a single package, one of them matgeom. Because matgeom doesn't work in Octave out of the box, it's being ported and made into a package here. However, not all functions have been ported yet and apparently you have hit one of them.

Carnë Draug <carandraug>
Project Member
Mon 22 Jul 2013 08:42:05 PM UTC, comment #3: 

Oh, I didn't know that Octave's geometry package was derived from another set of functions that are developed separately.

As I see it, inconsistencies like this will happen if we have two versions of a package maintained independently.  Why are we doing that?

John W. Eaton <jwe>
Project Administrator
Mon 22 Jul 2013 08:34:42 PM UTC, comment #2: 

Well, I did. But the rest of the geometry package also came from matGeom (at least, it says on the package page "Library for geometric computing extending MatGeom functions."). So I was was surprised that this one was not included.

Alex Burka <aburka>
Mon 22 Jul 2013 08:31:04 PM UTC, comment #1: 

It looks like matgeom is free software, but since it also appears to be a separate package that is independently maintained, I don't think it makes sense to include parts of it in the Octave Forge geometry package.  Why don't you just download and install it to use this function?

John W. Eaton <jwe>
Project Administrator
Mon 22 Jul 2013 08:20:31 PM UTC, original submission:  

I am porting some code from Matlab and it was using matGeom. The geometry package has most of the functions. But it does not include geom3d/planePoint. It's included here (hopefully I am not violating copyright).

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #28645:  planePoint.m added by None (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by juanpi (Posted a comment)
  • -email is unavailable- added by carandraug (maintainer of geometry package)
  • -email is unavailable- added by aburka (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-11-16 mtmiller StatusNone => Fixed
        Open/ClosedOpen => Closed
    2013-07-23 carandraug Carbon-Copy- => Added ajuanpi+dev@gmail.com
    2013-07-22 None Attached File- => Added planePoint.m, #28645

    Back to the top


    Powered by Savane 3.5