bugGNU Octave - Bugs: bug #36359, GUI Settings are not correctly...

 
 

bug #36359: GUI Settings are not correctly synced

Submitter:  Israel Herraiz <herraiz>
Submitted:  Tue 01 May 2012 06:06:02 AM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  jacobdawid
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 04 May 2012 06:21:04 PM UTC, comment #3: 
Israel Herraiz <herraiz>
Fri 04 May 2012 03:11:03 PM UTC, comment #2: 
Jacob Dawid <jacobdawid>
Fri 04 May 2012 03:03:01 PM UTC, comment #1: 

I have attached the patch sent by Israel Herraiz. Basically, the settings are synced when the SettingsDialog widget is being destroyed. Therefore, it has to be destroyed before the signal will be emitted that the settings changed.

Jacob Dawid <jacobdawid>
Tue 01 May 2012 06:06:02 AM UTC, original submission:  

The settings dialog is not correctly synced with the rest of the application. For instance, if I open the settings dialog, change the display columns for the file tree and close the dialog, the tree does not change. If I open and close again, now the tree is changed.

This is because the settings in the destructor of SettingsDialog are synced after the settingsChanged event is emitted. The SettingsDialog should be destructed before the event is emitted.

The attached patch fixes this. Now the settings have immediate effect after closing the settings dialog. Tested on Linux and Windows.

Israel Herraiz <herraiz>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #25764:  sync_settings.patch added by herraiz (800B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bpabbott (Updated the item)
  • -email is unavailable- added by herraiz (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-05-02 jacobdawid Open/ClosedOpen Closed
    2012-05-02 jacobdawid StatusNone Fixed
    2012-05-02 jacobdawid Assigned toNone jacobdawid
    2012-05-01 bpabbott SummarySettings are not correctly synced GUI Settings are not correctly synced
    2012-05-01 herraiz Attached File- Added sync_settings.patch, #25764

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code