bugGNU Octave - Bugs: bug #36359, GUI Settings are not correctly...

 
 

bug #36359: GUI Settings are not correctly synced

Submitted by:  Israel Herraiz <herraiz>
Submitted on:  Tue 01 May 2012 06:06:02 AM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: Jacob Dawid <jacobdawid>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 04 May 2012 06:21:04 PM UTC, comment #3:

I think you mean this changeset: http://hg.savannah.gnu.org/hgweb/octave/rev/8e9823066dad

Israel Herraiz <herraiz>
Fri 04 May 2012 03:11:03 PM UTC, comment #2:

See this changeset:
http://hg.savannah.gnu.org/hgweb/octave/rev/fa52c6e84ae0

Jacob Dawid <jacobdawid>
Project MemberIn charge of this item.
Fri 04 May 2012 03:03:01 PM UTC, comment #1:

I have attached the patch sent by Israel Herraiz. Basically, the settings are synced when the SettingsDialog widget is being destroyed. Therefore, it has to be destroyed before the signal will be emitted that the settings changed.

Jacob Dawid <jacobdawid>
Project MemberIn charge of this item.
Tue 01 May 2012 06:06:02 AM UTC, original submission:

The settings dialog is not correctly synced with the rest of the application. For instance, if I open the settings dialog, change the display columns for the file tree and close the dialog, the tree does not change. If I open and close again, now the tree is changed.

This is because the settings in the destructor of SettingsDialog are synced after the settingsChanged event is emitted. The SettingsDialog should be destructed before the event is emitted.

The attached patch fixes this. Now the settings have immediate effect after closing the settings dialog. Tested on Linux and Windows.

Israel Herraiz <herraiz>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #25764:  sync_settings.patch added by herraiz (800B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bpabbott (Updated the item)
  • -unavailable- added by herraiz (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 02 May 2012 07:16:17 PM UTCjacobdawidOpen/ClosedOpen=>Closed
    Wed 02 May 2012 07:15:24 PM UTCjacobdawidStatusNone=>Fixed
    Wed 02 May 2012 06:41:08 PM UTCjacobdawidAssigned toNone=>jacobdawid
    Tue 01 May 2012 08:52:50 PM UTCbpabbottSummarySettings are not correctly synced=>GUI Settings are not correctly synced
    Tue 01 May 2012 06:06:02 AM UTCherraizAttached File-=>Added sync_settings.patch, #25764

    Back to the top


    Powered by Savane 3.1-cleanup1