bugGNU Octave - Bugs: bug #34280, unimplemented.m test fail (MinGW)

 
 

bug #34280: unimplemented.m test fail (MinGW)

Submitter:  Tatsuro MATSUOKA <tmacchant>
Submitted:  Tue 13 Sep 2011 12:00:59 AM UTC
   
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 30 Nov 2011 06:06:15 AM UTC, comment #8: 


>Does this test pass too now that bug #33669 has been resolved?

Yes! This FAIL does not appear now.

Tatsuro MATSUOKA <tmacchant>
Wed 30 Nov 2011 06:03:42 AM UTC, comment #7: 

Does this test pass too now that bug #33669 has been resolved?

Rik <rik5>
Group administrator
Mon 03 Oct 2011 10:18:20 PM UTC, comment #6: 

This looks to be caused by the same issue as bug #33669.  I posted a patch there for _makeinfo_ which is awaiting review by JWE.

Rik <rik5>
Group administrator
Tue 20 Sep 2011 06:51:00 PM UTC, comment #5: 

OK, so the text returned by unimplemented is starting out with a CR and a SPC.

The help functions look for things like "\n " but not "\r\n " or "\r ".

 I seem to remember this problem once before, so I thought it was already solved.  Before I change the functions in the help directory, we should try to find the previous discussion to understand what was done in the past (if anything) so we can maybe understand why it is not working now.  I really don't want to have to have every part of Octave that deals with text have to look for "\r\n", "\r", and "\n"...

John W. Eaton <jwe>
Group administrator
Tue 20 Sep 2011 06:49:14 AM UTC, comment #4: 


>What does
>toascii (unimplemented ("quad2d"))
>show you?



octave:34> toascii (unimplemented ("quad2d"))
ans =

 Columns 1 through 33:

    13    32   113   117    97   100    50   100    32   105   115    32   110   111   116    32   105   109   112   108   101   109   101   110   116   101   100    46    32    32    67   111   110

 Columns 34 through 66:

   115   105   100   101   114    32   117   115   105   110   103    32   100    98   108   113   117    97   100    46    13    32    13    32    80   108   101    97   115   101    32   114   101

 Columns 67 through 99:

    97   100    10    96   104   116   116   112    58    47    47   119   119   119    46   111    99   116    97   118   101    46   111   114   103    47   109   105   115   115   105   110   103

 Columns 100 through 132:

    46   104   116   109   108    39    32   116   111    32   108   101    97   114   110    32   104   111   119    32   121   111   117    32    99    97   110    32    99   111   110   116   114

 Columns 133 through 165:

   105    98   117   116   101    10   109   105   115   115   105   110   103    32   102   117   110    99   116   105   111   110    97   108   105   116   121    46    13    32    13    10    10


Tatsuro MATSUOKA <tmacchant>
Tue 20 Sep 2011 06:12:50 AM UTC, comment #3: 

My guess is that makeinfo is inserting some carriage return (ASCII 13) characters in the output that we are not accounting for.  What does


toascii (unimplemented ("quad2d"))


show you?

John W. Eaton <jwe>
Group administrator
Thu 15 Sep 2011 05:46:32 AM UTC, comment #2: 

I have struggled to see what happened.


octave:1>  test unimplemented
  ***** test
 str = unimplemented ("no_name_function");
 assert (isempty (str));
 str = unimplemented ("quad2d");
 assert (str(1:51), "quad2d is not implemented.  Consider using dblquad.");
 str = unimplemented ("MException");
 assert (str(1:58), "the `MException' function is not yet implemented in Octave");
!!!!! test failed
assert (str (1:51),"quad2d is not implemented.  Consider using dblquad.") expected
quad2d is not implemented.  Consider using dblquad.
but got
 quad2d is not implemented.  Consider using dblqua
octave:2> str = unimplemented ("quad2d");
octave:3> str
 Please readot implemented.  Consider using dblquad.
`http://www.octave.org/missing.html' to learn how you can contribute
 issing functionality.


octave:4> str(1:51)
 quad2d is not implemented.  Consider using dblqua
octave:5> str(1:53)
 quad2d is not implemented.  Consider using dblquad.
octave:6> whos
Variables in the current scope:

   Attr Name        Size                     Bytes  Class
   ==== ====        ====                     =====  =====
        ans         1x53                        53  char
        str         1x165                      165  char

Total is 218 elements using 218 bytes

octave:7> str(1:153)
 Please readot implemented.  Consider using dblquad.
`http://www.octave.org/missing.html' to learn how you can contribute
missing functio
octave:8>


Any suggestions?

Tatsuro MATSUOKA <tmacchant>
Wed 14 Sep 2011 01:19:47 AM UTC, comment #1: 

It looks like the string returned from unimplemented has a leading space character that we are not expecting.  Why is that happening?

John W. Eaton <jwe>
Group administrator
Tue 13 Sep 2011 12:00:59 AM UTC, original submission:  


  ***** test
 str = unimplemented ("no_name_function");
 assert (isempty (str));
 str = unimplemented ("quad2d");
 assert (str(1:51), "quad2d is not implemented.  Consider using dblquad.");
 str = unimplemented ("MException");
 assert (str(1:58), "the `MException' function is not yet implemented in Octave");
!!!!! test failed
assert (str (1:51),"quad2d is not implemented.  Consider using dblquad.") expected
quad2d is not implemented.  Consider using dblquad.
but got

 quad2d is not implemented.  Consider using dblqua


Tatsuro MATSUOKA <tmacchant>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by tmacchant (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-11-30 rik5 StatusNone Fixed
        Open/ClosedOpen Closed
    2011-10-03 rik5 Dependencies- Depends on bugs #33669

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code