bugGNU Octave - Bugs: bug #34169, Support -f compiler flags in...

 
 

bug #34169: Support -f compiler flags in mkoctfile

Submitted by:  Orion Poplawski <opoplawski>
Submitted on:  Mon 29 Aug 2011 10:10:20 PM UTC  
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Orion Poplawski Open/Closed:  Closed
Release:  3.4.2 Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 14 Feb 2015 06:43:50 AM UTC, comment #5: 

Octave now passes through unrecognized option arguments beginning with '-' to the underlying compiler.  I made the change in this cset (http://hg.savannah.gnu.org/hgweb/octave/rev/b59aabc08e63).  Closing report.

Rik <rik5>
Project Administrator
Sun 11 Sep 2011 07:47:06 PM UTC, comment #4: 

Why would it cause problems? You can call OpenMP parallellized functions from serial code..

Susi Lehtola <jussilehtola>
Tue 30 Aug 2011 03:30:43 PM UTC, comment #3: 

This came up because a compile of GMT with openMP and octave support resulted in mkoctfile getting passed the -fopenmp flag.  OpenMP support in octave is listed as experimental and is currently disabled in the Fedora builds.  I'm assuming that when building octave modules you would want to use the same flags as used by the main build and that passing in -fopenmp when octave was compiled without it would cause problems.  Thoughts?

Orion Poplawski <opoplawski>
Mon 29 Aug 2011 10:25:14 PM UTC, comment #2: 

I have to say I agree, I'm just lazy and this seemed the easiest to do.

Orion Poplawski <opoplawski>
Mon 29 Aug 2011 10:23:07 PM UTC, comment #1: 

I think this is the wrong fix. There are many other useful flags we could pass to the compiler, and manually adding each to mkoctfile seems laborious. Rather, it should probably simply pass any unrecognised flags to the compilation command, and we should only make mkoctfile itself accept long options as to reduce the likelihood of clashing with one of the compiler's short options (maybe even prefix them, e.g. --mko-mex, --mko-print).

Note that there is also src/mkoctfile.cc.in for the benefit of our POSIX-hating Windows friends which this patch ignores. Also see this thread:

http://octave.1599824.n4.nabble.com/I-think-I-quot-broke-quot-mkoctfile-for-3-4-1-td3608378.html

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Mon 29 Aug 2011 10:10:20 PM UTC, original submission:  

mkoctfile does not recognize -f compiler flags.  It should pass them on to the compiler.  The attached patch should fix.

Orion Poplawski <opoplawski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #23898:  octave-mkoctfile-flags.patch added by opoplawski (2KiB - text/x-patch - Patch to support -fFLAGS in mkoctfile)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jussilehtola (Posted a comment)
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by opoplawski (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-02-14 rik5 StatusNone => Fixed
        Open/ClosedOpen => Closed
    2011-08-29 opoplawski Attached File- => Added octave-mkoctfile-flags.patch, #23898

    Back to the top


    Powered by Savane 3.5