GNU Astronomy Utilities - Tasks: task #16288, Warp: warn users when WCSLIB...
You are not allowed to post comments on this tracker with your current authentication level.
task #16288: Warp: warn users when WCSLIB version is <7.12
Submitter: | Pedram Ashofteh-Ardakani <pedram> | ||
Submitted: | Wed 07 Dec 2022 08:52:13 PM UTC | ||
Should Start On: | Wed 07 Dec 2022 12:00:00 AM UTC | Should be Finished on: | Wed 07 Dec 2022 12:00:00 AM UTC |
Category: | Warp | Priority: | 5 - Normal |
Item Group: | Crash | Status: | None |
Privacy: | Public | Percent Complete: | 0% |
Assigned to: | None | Open/Closed: | Open |
Effort: | 0.00 |
Jump to the original submission
Sun 02 Apr 2023 10:20:57 AM UTC, comment #9: |
Labib Asari <labeeb7z> |
Wed 29 Mar 2023 03:59:12 PM UTC, comment #8: Right Labib :) For other readers who might be interested, here is a reference about distribution of negation over a logic statement, which states:
|
Pedram Ashofteh-Ardakani <pedram>![]() |
Wed 29 Mar 2023 12:46:04 PM UTC, comment #7: Thanks Pedram, you were right,
|
Labib Asari <labeeb7z> |
Wed 29 Mar 2023 11:55:30 AM UTC, comment #6: Oops, I found out the condition has a logical bug. For example, version 8.10 wouldn't pass the test correctly, since ver[1] < 12 and there's an && in the condition. To make it right, I suggest this alternative:
|
Pedram Ashofteh-Ardakani <pedram>![]() |
Wed 29 Mar 2023 11:18:35 AM UTC, comment #5: On another note, using negations in conditionals makes the logic complex and harder to understand. I'd suggest to replace the conditional from:
|
Pedram Ashofteh-Ardakani <pedram>![]() |
Wed 29 Mar 2023 11:02:39 AM UTC, comment #4: Nicely done Labib! The message is clear and concise, and the variables and checks are put in good places. Well done. You should go for the PR :) Mohammad will also take a look at it before merging to master and setting this task as complete.
|
Pedram Ashofteh-Ardakani <pedram>![]() |
Tue 28 Mar 2023 12:39:12 PM UTC, comment #3: Hey Pedram, I worked upon this and here's what I could come up with : https://github.com/labeeb-7z/GnuAstro/tree/wcslib-version-warning
|
Labib Asari <labeeb7z> |
Mon 27 Mar 2023 05:25:10 PM UTC, comment #2: Hello there Labib,
|
Pedram Ashofteh-Ardakani <pedram>![]() |
Mon 27 Mar 2023 04:43:27 PM UTC, comment #1: Hey Pedram, Im looking forward to solve this task.
|
Labib Asari <labeeb7z> |
Wed 07 Dec 2022 08:52:13 PM UTC, original submission:
Sepideh and Mohammad have already let Mark Callabreta know that WCSLIB 7.11 fails when calculating specific coordinates. He has fixed it in WCSLIB 7.12, and in the changelog pointed out:
|
Pedram Ashofteh-Ardakani <pedram>![]() |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Powered by Savane 3.12.
Corresponding source code
I believe my fork is ready to be reviewed.
If anyone has any additional points they'd like to add, please let me know!
Otherwise Mohammad can merge it with his approval.