GNU Astronomy Utilities - Tasks: task #16073, --copykeys of Fits program takes...
You are not allowed to post comments on this tracker with your current authentication level.
task #16073: --copykeys of Fits program takes keyword names also
Submitter: | Mohammad Akhlaghi <makhlaghi> | ||
Submitted: | Thu 11 Nov 2021 11:31:09 PM UTC | ||
Should Start On: | Thu 11 Nov 2021 12:00:00 AM UTC | Should be Finished on: | Thu 11 Nov 2021 12:00:00 AM UTC |
Category: | Fits | Priority: | 5 - Normal |
Item Group: | Enhancement | Status: | Postponed |
Privacy: | Public | Assigned to: | None |
Percent Complete: | 100% | Open/Closed: | Closed |
Effort: | 0.00 |
Jump to the original submission
Tue 19 Apr 2022 07:07:15 PM UTC, comment #11: |
Mohammad Akhlaghi <makhlaghi> |
Mon 18 Apr 2022 09:56:42 AM UTC, comment #10: Thanks for the comprehensive review! I have gone through all the points you have made and the changes in the code in detail, to understand what could've been improved in my approach.
I will start testing this branch, and notify here if I find any bugs. I've printed, filled, and submitted the copyright assignment form, they should get back to me soon. |
Jash Shah <jash_shah> |
Mon 18 Apr 2022 12:44:11 AM UTC, comment #9: Thanks a lot Jash, the code has become much better, allowing me to dig into the details. You can see my commit, with a full description of the changes I made in the commit message: https://codeberg.org/gnuastro/gnuastro/commit/e33704e43f0
|
Mohammad Akhlaghi <makhlaghi> |
Wed 06 Apr 2022 08:47:46 PM UTC, comment #8: Hey, here's all the updates I made:
|
Jash Shah <jash_shah> |
Tue 05 Apr 2022 07:12:25 AM UTC, comment #7: Sorry for all the mistakes, I should've followed the developing chapter more closely (^_^)/.
|
Jash Shah <jash_shah> |
Sat 02 Apr 2022 11:30:33 PM UTC, comment #6: Thanks a lot Jash. Here are some comments:
|
Mohammad Akhlaghi <makhlaghi> |
Sat 26 Mar 2022 04:17:15 PM UTC, comment #5: Hey Mohammad,
|
Jash Shah <jash_shah> |
Sat 26 Mar 2022 10:39:54 AM UTC, comment #4: Very good progress Jash and congratulations on your first free software contribution :-).
|
Mohammad Akhlaghi <makhlaghi> |
Fri 25 Mar 2022 01:40:58 PM UTC, comment #3: Hey @makhlaghi, I've come with a crude solution to this for now, wanted to get your thoughts on it.
==== ui_check_copykeys() ====
==== keywords() ====
==== keywords_copykeys_str() ====
|
Jash Shah <jash_shah> |
Tue 22 Mar 2022 03:16:28 PM UTC, comment #2: Great! This will be a very convenient feature to have :-).
|
Mohammad Akhlaghi <makhlaghi> |
Tue 22 Mar 2022 03:02:16 PM UTC, comment #1: Hi, I think I can try adding this feature. It would be great if you could assign it to me.
|
Jash Shah <jash_shah> |
Thu 11 Nov 2021 11:31:09 PM UTC, original submission:
Currently the --copykeys option of Gnuastro's Fits program ('astfits') only takes a range of keyword positions and copies the whole patch of keywords to the output (see the description of this option in the book).
|
Mohammad Akhlaghi <makhlaghi> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2022-04-19 | makhlaghi | Open/Closed | Open | Closed | |
2022-04-18 | makhlaghi | Percent Complete | 60% | 100% | |
2022-03-26 | makhlaghi | Percent Complete | 0% | 60% | |
2021-11-11 | makhlaghi | Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-f8d8.
Corresponding source code
Congratulations on completing the copyright paperwork Jash!
Your commit has now been merged into the 'master' branch as Commit efdbb7586a, so I am closing the issue!
Your name is now on the second page of the PDF manual (currently the bleeding edge version): http://akhlaghi.org/gnuastro.pdf and you can get the most recent tarball (which now has your newly added feature) from here: http://akhlaghi.org/gnuastro-latest.tar.lz
Thanks also Juan for suggesting this very useful feature :-).