taskGNU TeXmacs - Tasks: task #12916, constref'ing arguments

 
 

You are not allowed to post comments on this tracker with your current authentification level.

task #12916: constref'ing arguments

Submitted by:  Miguel de Benito <mdbenito>
Submitted on:  Sun 27 Oct 2013 06:17:09 PM UTC  
 
Category: NoneShould Start On: Sat 26 Oct 2013 10:00:00 PM UTC
Should be Finished on: Sat 26 Oct 2013 10:00:00 PM UTCPriority: 3 - Low
Status: In ProgressPrivacy: Public
Percent Complete: 0%Assigned to: Miguel de Benito <mdbenito>
Open/Closed: OpenEffort: 0.00

Thu 02 Jan 2014 05:35:00 PM UTC, comment #1:

I've started a git branch with this stuff. Please contact me to coordinate (one can always hope... hehe)

Miguel de Benito <mdbenito>
Project MemberIn charge of this item.
Sun 27 Oct 2013 06:17:09 PM UTC, original submission:

A non-negligeable performace improvement is to be had by relying less on smart pointers and constref'ing arguments everywhere. This task is here so that we may comment on the progress and send patches with changes as atomic as possible, i.e. such that they may be applied into the trunk after peer-review.

See for instance the first attached patch, where I constref'ed a lot of usages of string in analyze.?pp, string.?pp and elsewhere.

Suggestions:

  1. We work with types, instead of files: first string, then tree, etc.
  2. We don't leave source files "unfinished", i.e. with some functions converted others not. Because we don't want to work on all types at the same time, "unfinished" is to be understood wrt. to a given type.
  3. We don't focus on this task, just maybe complete a few files from time to time, and check / update the task in savannah, etc.
  4. I don't know where changes would have greatest impact on performance, but I guess targeting basic data manipulation routines for strings and trees (next in the list) makes sense. Any ideas?
  5. We may start a new branch, but conflict-hell is just around the corner...
Miguel de Benito <mdbenito>
Project MemberIn charge of this item.

 

Attached Files
file #29490:  constref_string_uses01-rev7569.patch added by mdbenito (53kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mdbenito (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 27 Oct 2013 06:19:36 PM UTCmdbenitoAttached File-=>Added constref_string_uses01-rev7569.patch, #29490
    Sun 27 Oct 2013 06:17:26 PM UTCmdbenitoSummaryconsref\'ing=>constref'ing arguments

    Back to the top


    Powered by Savane 3.1-cleanup