Sat 23 Mar 2013 11:47:44 PM UTC, comment #2:
Hi Mark,
While evaluating the new tarball you attached I see that you removed references to mercury and ALPS; that's good. I've noticed, however, a few problems which are described below.
== Use of Linux ==
In the project INSTALL file and chapter 5 of the documentation, Installation, you refer to Linux as an operating system, please note that "Linux" is just a kernel of a more complex system that we like to refer to as GNU/Linux, to emphasize the ideals of the Free Software movement.
Would you mind changing references to Linux as an OS to GNU/Linux?
For more information, see http://www.gnu.org/gnu/linux-and-gnu.html.
Taking the above into account, the first paragraph on the INSTALL file should read similar to this:
"Spinner is developed on GNU/Linux and can be installed with a minimum of effort
on any Debian-based distribution. It depends on the boost libraries, version 1.32
or 1.33, and compiles with g++ versions 4.0 and 3.6. It should be easy to
install spinner on any system where these programs are installed."
Or, if you decide to use a completely free distribution for development:
"Spinner is developed on [Trisquel, gNewSense, etc.] GNU/Linux and can be
installed with a minimum of effort on any Debian-based distribution. It depends
on the boost libraries, version 1.32 or 1.33, and compiles with g++ versions 4.0
and 3.6. It should be easy to install spinner on any system where these programs
are installed."
== Copyright and license notices ==
Please write appropriate copyright and license notices, at the beginning of all of your source (non-derivative) files. http://www.gnu.org/licenses/gpl-howto.html and http://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html are good starting points to understand these issues and provide standard templates; please use them to speed up approval. More answers at http://www.gnu.org/licenses/gpl-faq.html. For the GFDL, check http://www.gnu.org/licenses/fdl-howto.html.
Check for example the following files in your project:
- ChangeLog: Change log files should have a copyright notice and license notice at the end, since new material is added at the beginning but the end remains the end. See http://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html.
- Documentation files: The documentation seems to be distributed under a GPL version 2 license, according to gpl.texi, but the source *.texi files have a different license header. You should update the license headers in these files to use the standard license header recommended in http://www.gnu.org/licenses/gpl-howto.html. Or did you want to distribute the documentation under a different license? In any case, please make it clear what license is applied to the software and what license to the documentation.
- Files in the examples directory: Are these files licensed under GPL version 2 as well? If they are, or if they are licensed under any other free license, please add copyright and license notices to their respective README files.
- Files in the src directory: banners.hpp, makefile and metropolis_heisenberg.hpp are missing copyright and license notices. Cfn.cpp, Cfn.cpp.backup and lattice_graph.cpp have copyright notices, but need license notices as well.
For information on how to use copyright notices see http://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html. For information on how to use the GPL license header see http://www.gnu.org/licenses/gpl-howto.html. You already applied them correctly to the other source files, so take them as reference for the ones listed above.
You may also find useful looking at emacs source code as a reference for how to apply such notices.
Please apply the changes indicated above and attach a new tarball for revision. We will approve your project after that if everything is OK.
Regards,
|