mainSavannah Administration - Support: sr #109041, Resquests and question for...

 
 

sr #109041: Resquests and question for Gnuastro's git repo

Submitter:  Mohammad Akhlaghi <makhlaghi>
Submitted:  Tue 17 May 2016 04:13:43 PM UTC
   
 
Category:  Source code repositories - developer access Priority:  5 - Normal
Severity:  4 - Important Status:  Done
Privacy:  Public Assigned to:  rwp
Operating System:  GNU/Linux Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 24 Jul 2016 11:17:55 PM UTC, comment #17: 

I am also sorry for not being able to test it earlier. I have been so busy these last few weeks.

Thank you so much for all the great support and help.

Mohammad Akhlaghi <makhlaghi>
Sun 24 Jul 2016 11:13:47 PM UTC, comment #16: 

It looks like the Subject: is now being added properly. Yay!

  http://lists.gnu.org/archive/html/gnuastro-commits/2016-05/index.html

I am sorry it took so long to get this fixed for you. Thank you for your patience!

Since it looks like it is working I am closing this ticket as done. Please let us know if you need anything more.

Happy Hacking! :-)

Bob Proulx <rwp>
Site Administrator
Thu 07 Jul 2016 11:35:27 AM UTC, comment #15: 

Thank you very much, we will check the fixes and let you know.

Thanks again :-).

Mohammad Akhlaghi <makhlaghi>
Wed 06 Jul 2016 10:13:24 PM UTC, comment #14: 

Regarding access control...

I have set up a git pre-receive hook that checks for access control.  Currently only you (makhlaghi) can commit to the master branch using the hook as I have set it up. Hopefully. It is a little hard for me to test. But I think it should work. Other branches will accept check-ins from other members.

This really isn't set up in a scalable way if everyone wanted to do this. But it isn't difficult to do in a small number.

Bob Proulx <rwp>
Site Administrator
Wed 06 Jul 2016 09:03:19 PM UTC, comment #13: 

I am going to address only the original problem in this posting.  I will address the next thing next.  Sorry things have taken so long.

I think I may have fixed the subject line problem. It was a combination of versions of the files in git_multimail.py and post-receive and config. (However now I am not sure how it was working for elpa that I cloned for this.) The combination of files are working for me on my test setup that I constructed to debug this problem. I think that will work for you too. I look forward to the next commit so we can see if that is working.


Bob Proulx <rwp>
Site Administrator
Sun 03 Jul 2016 12:49:26 PM UTC, comment #12: 

Besides the previous requests, would it be possible to allow pushing to master to be limited to the maintainer (currently me).

The reason I am asking this is that being a member of the project on Savannah is very encouraging to those who are just starting to contribute. As members, they can also participate in the bug and task trackers. However since all members have full access to the git repo, we cannot easily accept new Savannah members to Gnuastro. So it would be great if this could be implemented to encourage new active participants.

Thanks in advance.

Mohammad Akhlaghi <makhlaghi>
Wed 25 May 2016 08:37:58 AM UTC, comment #11: 

Thank you for the update, I really appreciate it. We are looking forward to the email subject problem fix. I understand your busy schedule and really appreciate your prompt replies.

Just as a reminder, I would also be most grateful if you could remove the `[gnuastro]' string at the start of the email subjects, the gnuastro-commits mailing list also adds a `[gnuastro-commits]'string, making the single `[gnuastro]' redundant and taking space in the small subject lines. We can remove `[gnuastro-commits]' from the mailing list settings, but `[gnuastro]' is too generic (since we have several mailing lists), so removing `[gnuastro]' is the better solution.

As a further request, any time you get the chance, I wanted to see if is it possible to set up Gnuastro's repo such that the `origin/HEAD' branch (as viewed by someone who clones Gnuastro) is not cloned. It can be removed locally after the clone. But that is an extra step for each user and if it can be done on the server side once, it will be more cleaner.

By the way, after some further pushes (that involved multiple commits) I noticed the value of the summary email, it is indeed a very useful thing, thank you.

Mohammad Akhlaghi <makhlaghi>
Wed 25 May 2016 07:44:49 AM UTC, comment #10: 

Sorry for the delay. Urgent Savannah issues consumed my volunteer time this last week.  The subject problem is still on my list.

Bob Proulx <rwp>
Site Administrator
Wed 18 May 2016 07:07:09 PM UTC, comment #9: 

I saw that subject problem too.  I don't know why there wasn't a subject on that message.  I will investigate.

You only made one commit and therefore had two emails.  One was a summary of the entire git action.  The other was the single commit.  At that point it feels like 100% overhead for having two emails.  But normally a push will include a long list of individual commits.  At that time you will again get one summary message concerning the entire git operation and then will have a loooonnng list of messages containing the individual commits.  At that time it is a very useful summary message.  Check out this summary and long list of associated commits for an example.  (If you really don't like this then I forget but I do think the summary can be disabled.)

  https://lists.gnu.org/archive/html/emacs-diffs/2016-05/msg00019.html

The tar.gz you are referring to is associated with your 0.0 tag.  You have a tag there and therefore cgit makes it possible to download an associated tar.gz file.  You can only remove the listing of that tar.gz by having the tag removed.  But normally you simply tag a new release.  That will produce a new tar.gz download link associated with that tag.  See the coreutils project for an example of this when there are a normal flow of tags.

I will look into what happened with the subject line.

Bob Proulx <rwp>
Site Administrator
Wed 18 May 2016 03:50:41 PM UTC, comment #8: 

I would also like to see if it is possible to remove the .tar.gz tarball from the top cgit web interface?

In Gnuastro, the version controlled source needs to be bootstrapped to create the standard release tarball (that has the standard gnuastro-X.X.tar.gz name). I am affraid that having two tarballs with the same name might be confusing for people who visit the cgit web interface. The place where the actual gnuastro-X.X.tar.gz should be downloaded is from the FTP server.

Sorry for all the requests and great thanks for all the help.

Mohammad Akhlaghi <makhlaghi>
Wed 18 May 2016 12:53:21 PM UTC, comment #7: 

Sorry, it would also be great if the email subject is the title (first line) of the commit message.

Mohammad Akhlaghi <makhlaghi>
Wed 18 May 2016 12:52:15 PM UTC, comment #6: 

I made a commit after this new setup, thank you. You can see the mails sent to the mailing list here:

http://lists.gnu.org/archive/html/gnuastro-commits/2016-05/index.html

There are two emails: one with a subject "[gnuastro] master updated (cbd48f1 -> 7d516ca)" and the other with no subject. the one with a subject only has a very short summary and no commit message. While the second (without a subject) has the commit message along with the diff.

Is it somehow possible to set it up such that only one mail is sent: with a subject, the commit message and the diff. Possibly also with no "[gnuastro]" at the start of the subject.

Thank you very much

Mohammad Akhlaghi <makhlaghi>
Wed 18 May 2016 06:40:48 AM UTC, comment #5: 

Oh good.  Since everything seems to be done I will mark this ticket as done.  However let us know if there is anything more we can do for you.

Bob Proulx <rwp>
Site Administrator
Wed 18 May 2016 03:23:41 AM UTC, comment #4: 

Thank you. I had made all the preparations and was just preparing the following post ;-).

1. Thank you very much, it is much better now.

2. I was just curious about the Git permissions (mainly for the future), thank you very much for clarifying. For the time being it is not an important issue since we are only two members for now.

But the project Git repo was just announced yesterday. So if we do attract more developers, it might be good to set such a system up, to avoid mistakes. Where only the maintainer can push to master, while the other developers can push to other branches.

3. Thanks a lot for addressing the issue so promptrly.

Mohammad Akhlaghi <makhlaghi>
Wed 18 May 2016 03:17:36 AM UTC, comment #3: 

And I think the git commits mail is set up and done.  The mailing list archive will get created upon the first time it receives mail.  That should happen after your next git push upload.

The only question left is about #2 the fine grained access control in a git hook.

Bob Proulx <rwp>
Site Administrator
Wed 18 May 2016 03:07:56 AM UTC, comment #2: 

I see you have created gnuastro-commits mailing list. (Aren't I a snoop!)  I will connect up your git commits to it.

Bob Proulx <rwp>
Site Administrator
Tue 17 May 2016 06:52:35 PM UTC, comment #1: 

1. Description changed as requested. (Unfortunately there is no web interface for this. One can only make requests as you have done. We would like to have this capability on the web interface but someone would need to write it.)

2. By default all project members have full access.  Finer grained control is possible using git hooks. So far no one has requested a git hook for access control such as this. Do you have a canned example that you would suggest? Otherwise it will need to be researched. I am sure this is fairly commonly used elsewhere.

3. Commit emails may be added.  This is a standard feature activated upon request.  Most projects send commit notifications to a project-commits mailing list in order to keep large pushes from overwhelming the discussion.  A -commits list can be created in the mailing list configure administration menu. I am happy to send these to the -devel list but I recommend using a -commits list.

Bob Proulx <rwp>
Site Administrator
Tue 17 May 2016 04:13:43 PM UTC, original submission:  

The GNU Astronomy Utilities (Gnuastro) git repository was recently pushed to Savannah. I and had the following requests and questions:

1. Adding a cgit description for Gnuastro. Currently in the cgit web interface it says "Unnamed repository; edit this file 'description' to name the repository." under the title. Is it possible to change it to "GNU Astronomy Utilities"?

2. Do all Savannah project members have full access to the Git repo? Is it possible to for example allow special users to push to the master branch?

3.Commit emails to the -email is unavailable- mailing list. So a mail is sent on to this address on commit that is pushed to the main repository.

Thank you very much for maintaining the good service of Savannah.

Mohammad Akhlaghi <makhlaghi>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rwp (Posted a comment)
  • -email is unavailable- added by makhlaghi (Submitted the item)
  • -email is unavailable- added by makhlaghi
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-24 rwp StatusIn Progress Done
        Open/ClosedOpen Closed
    2016-05-25 rwp StatusDone In Progress
    2016-05-18 rwp Open/ClosedClosed Open
    2016-05-18 rwp StatusIn Progress Done
        Open/ClosedOpen Closed
    2016-05-17 rwp StatusNone In Progress
        Assigned toNone rwp
    2016-05-17 makhlaghi Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code