helpSavannah Administration - Support: sr #108748, Reassign mail filled with comments...

 
 

sr #108748: Reassign mail filled with comments from other project

Submitted by:  Sylvain Rochet <gradator>
Submitted on:  Mon Feb 16 10:14:39 2015  
 
Category: Savannah trackers - bugs, tasks, etc.Priority: 5 - Normal
Severity: 3 - NormalStatus: In Progress
Assigned to: Assaf Gordon <agn>Operating System: None
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue Feb 17 05:15:56 2015, comment #1:

I'm looking into this.
But it might take a while.

for reference, the complete email (with extraneous comments) is on the mailing list:
http://lists.nongnu.org/archive/html/lwip-devel/2015-02/msg00043.html

Assaf Gordon <agn>
Site AdministratorIn charge of this item.
Mon Feb 16 10:14:39 2015, original submission:

Hello,

I just re-assigned an item from bugs to task in lwIP tracker.

https://savannah.nongnu.org/bugs/?44077
to
https://savannah.nongnu.org/task/?13480

This is the notification email we got:

Date: Mon, 16 Feb 2015 10:05:57 +0000
From: Sylvain Rochet <INVALID.NOREPLY@gnu.org>
To: Krishna Shingala <krishna.shingala@nordicsemi.no>, lwip-devel@nongnu.org,
-unavailable-
Subject: [lwip-devel] [task #13480] lwIP as IPv6 only stack.
Reply-To: lwip-devel <lwip-devel@nongnu.org>

URL:
<http://savannah.nongnu.org/task/?13480>

Summary: lwIP as IPv6 only stack.
Project: lwIP - A Lightweight TCP/IP stack
Submitted by: kshingala
Submitted on: Mon 16 Feb 2015 10:05:56 AM GMT
Category: None
Severity: 3 - Normal
Item Group: None
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
Planned Release:
lwIP version: None

_____________________________________________________

Details:

6LoWPAN interfaces are being defined for many of the short range wireless
technolgies and these use cases require an embedded IPv6 only stack.

Today, while it is possible to use lwIP stack's IPv6 functionality, it is not
possible to not include reduncdant IPv4 portions of the stack, resulting in
large code size.

_____________________________________________________

Follow-up Comments:

-------------------------------------------------------
Date: Fri 24 Jun 2005 05:20:25 PM GMTBy: spiralvoice <spiralvoice>
Try patch #4125

-------------------------------------------------------
Date: Fri 24 Jun 2005 01:08:03 PM GMTBy: Anonymous
Might another check in configure.in be the source? If you look at:
---
# testing for gd support
LIBPNG=no
AC_CHECK_LIB(png, png_create_read_struct , [LIBPNG=yes])

LIBJPEG=no
AC_CHECK_LIB(jpeg, jpeg_CreateCompress, [LIBJPEG=yes])

LIBGD_GIF=no
AC_CHECK_LIB(gd, gdImageGif,[LIBGD_GIF=yes])

LIBGD_PNG=no
AC_CHECK_LIB(gd, gdImagePng, [LIBGD_PNG=yes])

LIBGD_JPG=no
AC_CHECK_LIB(gd, gdImageJpeg, [LIBGD_JPG=yes])
---
The first check for PNG check PNG read ability it seems
(png_create_read_struct), and it sets the variable LIBPNG. Is that variable
actually used anywhere? And if it is, without the GD PNG libraries, PNG
reading will still succeed. So it probably will try to read a file it cannot
write. Hence an error...
So LIBPNG can only be true when LIBGD_PNG is true, and LIBJPEG can only be
true when LIBGD_JPG is true.

-------------------------------------------------------
Date: Fri 24 Jun 2005 12:13:38 PM GMTBy: Anonymous
Anyone has clues what/where I should be looking for to fix this?

-------------------------------------------------------
Date: Fri 24 Jun 2005 12:11:26 PM GMTBy: Anonymous
I was too quick to judge. Running the .jpg version now: doesn't work.

No .jpg files are created, and also the webinterface (others? don't use them
myself) looks for the wrong files, still png:
<table class=bw_stats cellpadding=0 cellspacing=0 align=center><tr><td><img
src="bw_updown.png"></td></tr></table><br><table class=bw_stats cellpadding=0
cellspacing=0 align=center><tr><td><img
src="bw_h_updown.png"></td></tr></table>

-------------------------------------------------------
Date: Fri 24 Jun 2005 12:09:31 AM GMTBy: Anonymous
That last line is more clear in a seperate post:

I have added the compile time checks to gdstubs.c, compiles perfectly now. See
add_png_check.patch. Didn't have time to check the binairy yet, but I don't
expect problems.

-------------------------------------------------------
Date: Fri 24 Jun 2005 12:07:33 AM GMTBy: Anonymous

  • My config/configure.in now states:

LIBGD_GIF=no
AC_CHECK_LIB(gd, gdImageGif,[LIBGD_GIF=yes])

LIBGD_PNG=no
AC_CHECK_LIB(gd, gdImagePng, [LIBGD_PNG=yes])

LIBGD_JPG=no
AC_CHECK_LIB(gd, gdImageJpeg, [LIBGD_JPG=yes])

  • I have installed libgd with no png support. I guess configure sences it

correctly:

checking for png_create_read_struct in -lpng... yes
checking for jpeg_CreateCompress in -ljpeg... yes
checking for gdImageGif in -lgd... yes
checking for gdImagePng in -lgd... no
checking for gdImageJpeg in -lgd... yes
checking compile with gd... yes

  • But gdstubs still want to link against the png lib (so it seems)

ocamlopt.opt -inline 10 -linkall -o mlnet unix.cmxa str.cmxa -ccopt
"-L/usr/local/lib -I/usr/local/include" -cclib "-lcharset
/usr/local/lib/libiconv.so -Wl,-rpath -Wl,/usr/local/lib" -cclib -lz -cclib
-lgd -cclib -lpng -cclib -ljpeg -cclib -lfreetype -cclib -lm -ccopt
-DHAVE_JPEG -ccopt -W -ccopt -Wall -ccopt -Wno-unused -ccopt "-D_THREAD_SAFE
-pthread" -I build build/cdk.cmxa build/common.cmxa
build/client.cmxa build/core.cmxa build/driver.cmxa
src/daemon/common/commonMain.cmx
src/utils/cdk/gdstubs.o(.text+0x29c): In function `ml_image_open_png':
src/utils/cdk/gdstubs.c:151: undefined reference to `gdImageCreateFromPng'
src/utils/cdk/gdstubs.o(.text+0xa0b): In function `ml_save_png':
src/utils/cdk/gdstubs.c:341: undefined reference to `gdImagePng'
src/utils/cdk/gdstubs.o(.text+0xa9b): In function `ml_dump_png':
src/utils/cdk/gdstubs.c:371: undefined reference to `gdImagePngPtr'
Error during linking
gmake: *** [mlnet] Error 2

  • By the way, gif isn't used in gdstubs only png and jpeg. If it isn't used

anywhere in the code, then why check for it in configure? I have added the
compile time checks to gdstubs.c, compiles perfectly now. See
add_png_check.patch. Didn't have time to check the binairy yet, but I don't
expect problems.

-------------------------------------------------------
Date: Thu 23 Jun 2005 11:45:23 PM GMTBy: Anonymous

  • My config/configure.in now states:

LIBGD_GIF=no
AC_CHECK_LIB(gd, gdImageGif,[LIBGD_GIF=yes])

LIBGD_PNG=no
AC_CHECK_LIB(gd, gdImagePng, [LIBGD_PNG=yes])

LIBGD_JPG=no
AC_CHECK_LIB(gd, gdImageJpeg, [LIBGD_JPG=yes])

  • I have installed libgd with no png support. I guess configure sences it

correctly:

checking for png_create_read_struct in -lpng... yes
checking for jpeg_CreateCompress in -ljpeg... yes
checking for gdImageGif in -lgd... yes
checking for gdImagePng in -lgd... no
checking for gdImageJpeg in -lgd... yes
checking compile with gd... yes

  • But gdstubs still want to link against the png lib (so it seems)

ocamlopt.opt -inline 10 -linkall -o mlnet unix.cmxa str.cmxa -ccopt
"-L/usr/local/lib -I/usr/local/include" -cclib "-lcharset
/usr/local/lib/libiconv.so -Wl,-rpath -Wl,/usr/local/lib" -cclib -lz -cclib
-lgd -cclib -lpng -cclib -ljpeg -cclib -lfreetype -cclib -lm -ccopt
-DHAVE_JPEG -ccopt -W -ccopt -Wall -ccopt -Wno-unused -ccopt "-D_THREAD_SAFE
-pthread" -I build build/cdk.cmxa build/common.cmxa
build/client.cmxa build/core.cmxa build/driver.cmxa
src/daemon/common/commonMain.cmx
src/utils/cdk/gdstubs.o(.text+0x29c): In function `ml_image_open_png':
src/utils/cdk/gdstubs.c:151: undefined reference to `gdImageCreateFromPng'
src/utils/cdk/gdstubs.o(.text+0xa0b): In function `ml_save_png':
src/utils/cdk/gdstubs.c:341: undefined reference to `gdImagePng'
src/utils/cdk/gdstubs.o(.text+0xa9b): In function `ml_dump_png':
src/utils/cdk/gdstubs.c:371: undefined reference to `gdImagePngPtr'
Error during linking
gmake: *** [mlnet] Error 2

-------------------------------------------------------
Date: Thu 23 Jun 2005 04:08:14 PM GMTBy: Anonymous
Good one. But of course I now have a libgd with libpng. I will give it a try
to revert to the old situation and give it a test.

-------------------------------------------------------
Date: Thu 23 Jun 2005 03:55:56 PM GMTBy: spiralvoice <spiralvoice>
I committed your patch, yes of course it has to be changed.
Stupid bug though, can you now use MLDonkeys graphs with a
libgd which is compiled without libpng?

-------------------------------------------------------
Date: Thu 23 Jun 2005 03:20:19 PM GMTBy: Anonymous
This has nothing to do with all gd libs not being found when the LDFLAGS
variable isn't used... but should this patch be applied?

--- configure.in Mon Jun 20 20:52:57 2005
+++ ../../mldonkey_old/config/configure.in Thu Jun 23 17:11:29 2005
@@ -1033,7 +1033,7 @@
AC_CHECK_LIB(gd, gdImageGif,[LIBGD_GIF=yes])

LIBGD_PNG=no
-AC_CHECK_LIB(gd, gdImagePng, [LIBGD_JPG=yes])
+AC_CHECK_LIB(gd, gdImagePng, [LIBGD_PNG=yes])

LIBGD_JPG=no
AC_CHECK_LIB(gd, gdImageJpeg, [LIBGD_JPG=yes])

Somehow that seems more natural, but I have too little experience with it to
know that it is correct.

-------------------------------------------------------
Date: Thu 23 Jun 2005 09:07:58 AM GMTBy: Anonymous
Nevermind that last post. The problem was in gd afterall. There was no png
support compiled in. I updated my ports, reinstalled gd and now it works.

The only extra line I have to add to configure to make it work is:
LDFLAGS="-L/usr/local/lib"

I guess autoconf (AC_CHECK_LIB(gd, gdImagePng, [LIBGD_JPG=yes])) isn't doing
it's job properly.

-------------------------------------------------------
Date: Thu 23 Jun 2005 07:31:19 AM GMTBy: Anonymous
Maybe not yet. It seems the Gd libs are found when using this configure line:
./configure --enable-ocamlver=3 --with-libiconv-prefix=/usr/local/include
LDFLAGS="-L/usr/local/lib" CPPFLAGS="-I/usr/local/include"

However, somehow PNG support is not working. The configure script says:
checking for png_create_read_struct in -lpng... yes
checking for jpeg_CreateCompress in -ljpeg... yes
checking for gdImageGif in -lgd... yes
checking for gdImagePng in -lgd... no
checking for gdImageJpeg in -lgd... yes
checking compile with gd... yes

But appearently, that png support is crucial, because linking fails:
src/utils/cdk/gdstubs.o(.text+0x29c): In function `ml_image_open_png':
src/utils/cdk/gdstubs.c:151: undefined reference to `gdImageCreateFromPng'
src/utils/cdk/gdstubs.o(.text+0xa0b): In function `ml_save_png':
src/utils/cdk/gdstubs.c:341: undefined reference to `gdImagePng'
src/utils/cdk/gdstubs.o(.text+0xa9b): In function `ml_dump_png':
src/utils/cdk/gdstubs.c:371: undefined reference to `gdImagePngPtr'

I traced it down to be a Gd error though. Relevant parts of the Gd configure:
checking for libpng12-config... /usr/local/bin/libpng12-config
checking for libpng-config... /usr/local/bin/libpng-config
checking png.h usability... yes
checking png.h presence... yes
checking for png.h... yes
checking for png_create_read_struct in -lpng12... no
configure: WARNING: libpng is required - see http://www.libpng.org/pub/png/

    • Configuration summary for gd 2.0.33:

Support for PNG library:
Support for JPEG library: yes
Support for Freetype 2.x library: yes
Support for Fontconfig library: yes
Support for Xpm library: yes
Support for pthreads: yes

Maybe it is an idea to use GIF instead of PNG anyway? At least when its found
that PNG is not available.

-------------------------------------------------------
Date: Mon 20 Jun 2005 07:04:18 PM GMTBy: spiralvoice <spiralvoice>
So I can close this bug, yes?

-------------------------------------------------------
Date: Mon 20 Jun 2005 07:03:52 PM GMTBy: spiralvoice <spiralvoice>
I think this makes the difference, from Makefile:

CONFIGURE_ENV+= \
CPPFLAGS="${CPPFLAGS} -I${LOCALBASE}/include" \
LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib" \
PTHREAD_CFLAGS="${PTHREAD_CFLAGS}" \
PTHREAD_LIBS="${PTHREAD_LIBS}"

-------------------------------------------------------
Date: Mon 20 Jun 2005 05:46:36 PM GMTBy: Anonymous
Very interesting Spiralvoice, didn't know the port was that active.
Tried to figure out where the differences are, but I can't see. I think these
are the ./configure options they use:
--disable-gd --with-libiconv-prefix=/usr/local --disable-gui
--prefix=/usr/local i386-portbld-freebsd5.4 --enable-ocamlver=3

If I try a configure with these options it doesn't work. Hell, maybe I should
forget the static builds and use this port.

-------------------------------------------------------
Date: Mon 20 Jun 2005 05:06:31 PM GMTBy: spiralvoice <spiralvoice>
Try FreeBSD ports version:
http://www.freebsd.org/cgi/cvsweb.cgi/ports/net/mldonkey-devel/

There are some settings to include libs in /usr/local which are
not found by default by ./configure

-------------------------------------------------------
Date: Mon 20 Jun 2005 12:59:38 PM GMTBy: Anonymous

> libpng-config --version

1.2.8

> libpng-config --prefix

/usr/local

_____________________________________________________

File Attachments:

-------------------------------------------------------
Date: Fri 24 Jun 2005 12:07:33 AM GMT Name: add_png_check.patch Size: 1kB
By: White_FrosT
Add compile time check for PNG lib availability
<http://savannah.nongnu.org/bugs/download.php?file_id=3120>

_____________________________________________________

Reply to this item at:

<http://savannah.nongnu.org/task/?13480>

_____________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/

_____________________________________________
lwip-devel mailing list
-unavailable-
https://lists.nongnu.org/mailman/listinfo/lwip-devel

Sylvain Rochet <gradator>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by agn (Posted a comment)
  • -unavailable- added by gradator (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue Feb 17 05:15:56 2015agnStatusNone=>In Progress
      Assigned toNone=>agn

    Back to the top


    Powered by Savane 3.1-cleanup1