patchmake - Patches: patch #7243, small windows fixes

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7243: small windows fixes

Submitter:  Ozkan Sezer <sezero>
Submitted:  Thu 15 Jul 2010 01:03:37 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Fixed Release:  None

Mon 19 Jul 2010 07:01:42 AM UTC, comment #2: 

Can't see anything new in the cvs, is it normal??

Ozkan Sezer <sezero>
Sun 18 Jul 2010 11:15:09 PM UTC, comment #1: 

I've applied these changes.

Paul D. Smith <psmith>
Group administrator
Thu 15 Jul 2010 01:03:37 PM UTC, original submission:  

The attached patch does a few trivial windows fixes and restores MSVC support.  Tested by compiling for win32 and win64 (mingw-w64, MSVC), as well as for linux to verify that no breakage occured.

  • config.h.W32.template (_CRT_SECURE_NO_WARNINGS): Define for MSVC.

(_CRT_NONSTDC_NO_WARNINGS): Likewise.

  • NMakefile.template (LDFLAGS): Remove /MACHINE:I386 options.


  • make.h: For MSVC support, do not protoype alloca for WINDOWS32

targets, too, not just only for gcc.

  • job.c: Do not prototype any of the unistd.h functions for

WINDOWS32 when unistd.h is not available, as is the case with
MSVC.
(pid2str): Do not limit %Id to gcc => 4 because gcc-3.4.5 from
mingw.org understands %Id just fine, and the _GNUC_ > 3
condition eliminates the possibility of MSVC compiler being in
use.
(exec_command): Cast hWaitPID to pid_t, which is what pid2str()
accepts, instead of DWORD_PTR.

  • w32/compat/dirent.c: Include config.h.

(readdir): Cast -1 to ino_t when assigning it to a d_ino member
because ino_t can be unsigned.

  • w32/subproc/sub_proc.c: For MSVC, include stddef.h instead

of stdint.h for intptr_t. Move config.h include to be the first
and with <> instead of "" as it is done in make.h.

  • w32/subproc/misc.c: Include config.h.


  • w32/pathstuff.c: Move make.h include to be the first.


  • main.c (main, ADD_SIG): Define to (void)sig when sigsetmask is

not available to avoid statement with no effect warnings.


Ozkan Sezer <sezero>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #20984:  04_windows.diff added by sezero (8KiB - application/octet-stream - several windows fixes, 2010-07-15.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by sezero (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-18 psmith StatusNone Done
        Open/ClosedOpen Closed
    2010-07-15 sezero Attached File- Added 04_windows.diff, #20984

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code