make - Patches: patch #7241, check for strncasecmp and its...
You are not allowed to post comments on this tracker with your current authentication level.
patch #7241: check for strncasecmp and its replacements in configury
Submitter: | Ozkan Sezer <sezero> | ||
Submitted: | Thu 15 Jul 2010 12:46:55 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Fixed Release: | None |
Mon 19 Jul 2010 01:45:41 PM UTC, comment #5: |
Paul D. Smith <psmith> |
Mon 19 Jul 2010 07:27:22 AM UTC, comment #4: Thank you.
|
Ozkan Sezer <sezero> |
Mon 19 Jul 2010 07:13:20 AM UTC, comment #3: Committed now. |
Paul D. Smith <psmith> |
Mon 19 Jul 2010 07:00:22 AM UTC, comment #2:
|
Ozkan Sezer <sezero> |
Sun 18 Jul 2010 11:32:58 PM UTC, comment #1: I've applied this, thanks. Can you confirm the change to config.h.W32 for me? In that file already we define HAVE_STRCMPI and we do NOT define HAVE_STRICMP. But in your patch here you define HAVE_STRNICMP and do NOT define HAVE_STRNCMPI.
|
Paul D. Smith <psmith> |
Thu 15 Jul 2010 12:46:55 PM UTC, original submission:
Now that strncasecmp() is in use by the recently added is_bourne_compatible_shell() in job.c, it needs to be checked by the configury as it has been done for strcasecmp(). See the attached patch. Tested by compiling for linux, win32 and win64.
and strnicmp.
HAVE_STRNCMPI and HAVE_STRNICMP.
strcasecmp.
|
Ozkan Sezer <sezero> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2010-07-18 | psmith | Status | None | Done | |
Open/Closed | Open | Closed | |||
2010-07-15 | sezero | Attached File | - | Added strncasecmp.diff, #20982 |
Powered by Savane 3.13-02a9.
Corresponding source code
Actually not a merge error because that code did not appear in the patch: I added it myself :-). However you're right I somehow added the length argument to the wrong prototype. Fixed (to commit shortly). Thanks.