patchmake - Patches: patch #7213, Implicit rules don't recognize...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7213: Implicit rules don't recognize targets with whitespace in the stem

Submitter:  Kamil Mierzejewski <kmierzejewski>
Submitted:  Tue 01 Jun 2010 04:25:18 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Duplicate Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Fixed Release:  None

Mon 26 Jul 2010 02:42:17 PM UTC, comment #2: 

The problem is that backslash is a special character on some platforms supported by GNU make (e.g., it's a directory separator on DOS/Windows/OS2 systems).  So, we cannot just decide to start treating backslash as an escape character inside pathnames: that's a major backward-compatibility problem and will break a lot of makefiles.

In addition, this change is not sufficient to allow for whitespace in filenames in general, and when this gets solved I want to have a single, comprehensive solution rather than a number of ad hoc solutions.

Closed as a duplicate of bug #712

Paul D. Smith <psmith>
Group administrator
Mon 26 Jul 2010 12:47:39 PM UTC, comment #1: 

Gnu make 3.81.91 works on the sample provided, but is still vulnerable if .SECONDEXPANSION is turned on and a rule makes use of it:

%.txt:$$*.in
cp '$<' '$@'

Kamil Mierzejewski <kmierzejewski>
Tue 01 Jun 2010 04:25:18 PM UTC, original submission:  

Consider a simple makefile:

TARGET:=file\ with\ space.txt

all:$(TARGET)

%.txt:%.in
cp '$<' '$@'


Suppose that a file 'file with space.in' exists. The rule %.txt:%.in should match, but it doesn't because prerequisites are split on whitespace characters.

The patch changes the behavior by escaping whitespaces in stem before it is processed further.

Kamil Mierzejewski <kmierzejewski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #20671:  implicit_whitespace.patch added by kmierzejewski (862B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by donpellegrino (Voted in favor of this item)
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by kmierzejewski (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-18 donpellegrino Carbon-Copy- Added donpellegrino
    2010-07-26 psmith StatusNone Duplicate
        Open/ClosedOpen Closed
    2010-06-01 kmierzejewski Attached File- Added implicit_whitespace.patch, #20671

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code