patchmake - Patches: patch #3632, Support of quoted, fully qualified...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3632: Support of quoted, fully qualified LFN in W32

Submitter:  Hyoung Lee <hlee>
Submitted:  Mon 10 Jan 2005 10:59:43 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Fixed Release:  None

Sun 27 Feb 2005 09:06:27 PM UTC, comment #1: 

This patch is not sufficient to solve the problem.  There are many, many places in make where strings are parsed and broken up on whitespace.  For example, what  about using make functions on the filenames, as many, many makefiles do?  Functions almost always operate on words, defined by whitespace separators (addprefix, etc. etc.)  None of these will take quoting into account, and changing make to recognize quoting everywhere necessary to make this feature work properly is a huge amount of work...

And finally, while I definitely agree that there is a need for a comprehensive quoting mechanism in GNU make, I don't think using quotes to do it is the right approach for a final solution.

Paul D. Smith <psmith>
Group administrator
Mon 10 Jan 2005 10:59:43 PM UTC, original submission:  

1. Patch Definition

Fully qualified LFN with space characters may be used as target names provided such full path names are enclosed qith quotes; e.g., "C:\Program Files\My Files\..."

Fully qualified LFNs may be used as follow:

"C:\Demo Support\Object\intensitycal.obj" : "C:\Demo Support\C\intensitycal.c"
$(COMPILE) "C:\Demo Support\C\intensitycal.c"

2. Patch

read.c from V3.791 was modified to accept quoted, fully qualified syntax. To identify the fixes, I added "__QUOTED_LFN__" preprocessor directive. There are 4 instances in read.c (see attached).

The patch may also be verified by adding -D__QUOTED_LFN__ when compiling.

Hyoung Lee <hlee>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8240:  read.c added by hlee (76KiB - text/plain - make read file from V3.791 containing 4 instances of _QUOTED_LFN_ preprocessor directive)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-02-27 psmith StatusNone Wont Do
    Open/ClosedOpen Closed
2005-01-10 hlee Attached File- Added read.c, #4023

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code