GNUstep - Patches: patch #4415, base: mingw unicode filesystemRep
You are not allowed to post comments on this tracker with your current authentication level.
patch #4415: base: mingw unicode filesystemRep
Submitter: | Jeremy Bettis <jeremybettis> | ||
Submitted: | Tue 13 Sep 2005 06:38:25 PM UTC | ||
Category: | Foundation | Priority: | 5 - Normal |
Status: | Wont Do | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Sun 23 Oct 2005 02:58:29 PM UTC, comment #3: |
Richard Frith-Macdonald <CaS> |
Sun 23 Oct 2005 02:17:38 PM UTC, comment #2: I think it would be safer to tell the world that win32 works differently in the header file. For example, the change to filesystemRepresentation broke my code, and I didn't even know it. I updated by gnustep-base library to a new version, and didn't get a compiler warning or anything, but filesystemRepresentation only returned the first character of the string. (From my perspective interpreting it as a char*)
|
Jeremy Bettis <jeremybettis> |
Sun 23 Oct 2005 08:16:42 AM UTC, comment #1: Some of what this patch does is already in place ... the part that isn't is the change to the API.
|
Richard Frith-Macdonald <CaS> |
Tue 13 Sep 2005 06:38:25 PM UTC, original submission:
The filesystemRepresentation returns unicode, but doesn't declare the function that way. This patch resolvs that and fixes some usages that were treating it as a char*.
|
Jeremy Bettis <jeremybettis> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2005-10-23 | CaS | Status | None | Wont Do | |
Open/Closed | Open | Closed |
Powered by Savane 3.13-4448.
Corresponding source code
Quite right ... the header file should have told users about windows behavior. Unfortunately, while it got added to the documentation for the method in NSFileManager, it got missed from NSString. I've added the appropriate documentation.
Really, the methods should use void* as the actual type of data is theoretically dependent on the filesystem being used, but the OpenStep spec and MacOS-X use char*