patchGNUstep - Patches: patch #3498, Fix some parameter names in C...

Group
 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3498: Fix some parameter names in C function definitions

Submitter:  Patrick Middleton <patrickx>
Submitted:  Tue 02 Nov 2004 02:57:33 PM UTC
   
 
Category:  AppKit Priority:  5 - Normal
Status:  Invalid Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Fri 05 Nov 2004 04:39:06 PM UTC, comment #2: 

Cough.

It appears my problem report was thoroughly bogus, and the patch I submitted is redundant.  In order to get out some macro definition information, I added -dM to ADDITIONAL_OBJCFLAGS.  Except what I actually added was -Dm .  I'd have realised my error sooner, except that I saw the problem I was describing several years ago with the NeXT-supplied gcc 2.7.2.1.  Still, it makes a novel argument against the use of single-letter variable names.

Grin?

Patrick Middleton <patrickx>
Thu 04 Nov 2004 08:13:22 PM UTC, comment #1: 

I never heard of such a compiler bug. Could you please give an expample of the error you are getting? I have been compiling GNUstep wiht various gcc releases on both Linux and Windows (with Cygwin though) and never did get such a warning/error.
The patch itself is fine with me, I would just like to understand why it is needed.

Fred Kiefer <FredKiefer>
Group Member
Tue 02 Nov 2004 02:57:33 PM UTC, original submission:  

Because of what appears to be a known bug/misfeature in the ObjC compiler, type information associated with parameter names in function definitions is remembered and causes compilation errors when the same parameter names are used with different type in ObjC method definitions.

Parameter names are optional in C function definitions, but not in inline function declarations or in in ObjC method definitions, so I chose to adopt lengthy clumsy descriptive names implying type information.  This probably does not conform to GNU coding recommendations and is going to look hideous if processed by eg 'headerdoc'.  But it compiles.

I was using the MinGW compiler etc provided by the recent base-1.10.0 installer on WinXP SP1.

(There is a small amount of similar trouble elsewhere; one of the base-1.10.0 objc headers contains one function for which a parameter name 'm' has not been removed, and this causes problems when compiling NSPortMessage.[hm].)


Patrick Middleton <patrickx>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8006:  AppKit-function-definitions.patch added by patrickx (79KiB - Patch against gnustep-gui-0.9.4)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2004-11-11 fedor StatusNone Invalid
    Open/ClosedOpen Closed
2004-11-02 patrickx Attached File- Added AppKit-function-definitions.patch, #3845

Back to the top

Powered by Savane 3.13-4448.
Corresponding source code