patchMIT/GNU Scheme - Patches: patch #9205, Fix deinstall of multiplexer when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9205: Fix deinstall of multiplexer when a default exists.

Submitter:  Daniel White <dwhite>
Submitted:  Mon 02 Jan 2017 03:17:39 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  riastradh Open/Closed:  Closed

Mon 02 Jan 2017 03:48:46 PM UTC, comment #2: 

Merged, thanks!

Taylor R. Campbell <riastradh>
Group Member
Mon 02 Jan 2017 03:19:28 PM UTC, comment #1: 

In hindsight, I perhaps should have noted it is the generic procedure multiplexer.

Daniel White <dwhite>
Mon 02 Jan 2017 03:17:39 PM UTC, original submission:  

This copes with a somewhat subtle case where a default exists but the
last generator is removed. By inverting the checks, we can ensure we
only look at the cdr of the generator list when generators is actually a
pair.

The bug was originally exhibited by an error when removing the last
generator with remove-generic-procedure-generator on a generic procedure
with a default generator.

I've added a somewhat clumsy test case, which I figured was an improvement
over having nothing at all. I'm happy to twiddle with it a bit more if there are
any better suggestions or recommendations around how to tackle it.

Daniel White <dwhite>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by riastradh (Posted a comment)
  • -email is unavailable- added by dwhite (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-01-02 riastradh StatusNone Done
        Assigned toNone riastradh
        Open/ClosedOpen Closed
    2017-01-02 dwhite Attached File- Added 0001-Fix-deinstall-of-multiplexer-when-a-default-exists.patch, #39341

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code