patchPSPP - Patches: patch #8674, gtk3 - psppire crashed when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8674: gtk3 - psppire crashed when exiting due to tt_options_dialog_destroy

Submitter:  Friedrich Beckmann <beckmanf>
Submitted:  Sun 17 May 2015 01:28:32 PM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 17 May 2015 05:19:06 PM UTC, comment #3: 

I pushed this one.

John Darrington <jmd>
Group administrator
Sun 17 May 2015 02:23:43 PM UTC, comment #2: 

Hi John,

i attached an alternative patch that I tested which checks the NULL condition in the callee as you propose. Tested this on debian 8.

(file #34031)

Friedrich Beckmann <beckmanf>
Group Member
Sun 17 May 2015 02:07:57 PM UTC, comment #1: 

Good catch.

The convention we use elsewhere, is to check for the NULL condition in callee.  That is to say inside tt_options_dialog_destroy rather than from where it is called.

John Darrington <jmd>
Group administrator
Sun 17 May 2015 01:28:32 PM UTC, original submission:  

This patch applies to gtk3. I tested on debian 8. psppire crashed when I exit psppire. This is due to tt_options_dialog_destroy which is called without the create function first. The reason is that it is assumed that the activate function is called but this is not the case.

Friedrich

Friedrich Beckmann <beckmanf>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by beckmanf (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-05-17 jmd StatusNone Done
        Open/ClosedOpen Closed
    2015-05-17 beckmanf Attached File- Added 0001-gtk3-added-NULL-check-to-tt_test_options_dialog_dest.patch, #34031
    2015-05-17 beckmanf Attached File- Added gtk3-tt_options_dialog_destroy.patch, #34030

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code