patchPSPP - Patches: patch #8661, bug #44012 - patch to fix GRAPH...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8661: bug #44012 - patch to fix GRAPH SCATTERPLOT crashes gui

Submitter:  Friedrich Beckmann <beckmanf>
Submitted:  Fri 24 Apr 2015 05:59:47 AM UTC
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Mon 25 May 2015 08:47:57 AM UTC, comment #4: 
Friedrich Beckmann <beckmanf>
Project Member
Fri 24 Apr 2015 07:21:06 PM UTC, comment #3: 

Hi John,

thank you!

Friedrich

Friedrich Beckmann <beckmanf>
Project Member
Fri 24 Apr 2015 07:09:16 PM UTC, comment #2: 

Good work.

I pushed these patches with some very minor alterations.

John Darrington <jmd>
Project Administrator
Fri 24 Apr 2015 06:20:03 AM UTC, comment #1: 

Johns proposed changes regarding formatting and others are described here:

http://lists.gnu.org/archive/html/pspp-dev/2014-10/msg00001.html

That is the content of patch 0001-....

Friedrich

Friedrich Beckmann <beckmanf>
Project Member
Fri 24 Apr 2015 05:59:47 AM UTC, original submission:  

This are 3 patches to fix bug #44012 - GRAPH SCATTERPLOT crashes gui and one minor issue regarding the title of the plots.

https://savannah.gnu.org/bugs/?44012

As John already noted, the problem is that data is used during chart drawing which is not valid anymore when the chart is drawn. I followed the strategy used in npplot now also for scatterplot, i.e. a new case reader is created and finally destroyed in the chart.

The patches are

1 - Comments from John regarding formatting of the code
2 - The actual fix of bug #44012
3 - A fix regarding x vs. y or y vs. x title see:

http://lists.gnu.org/archive/html/pspp-users/2015-02/msg00006.html

Friedrich

Friedrich Beckmann <beckmanf>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #33750:  0001-added-space-between-function-name-and-left-bracket-t.patch added by beckmanf (11KiB - application/octet-stream - patches to fix bug #44012, formatting and x vs. y title)
file #33751:  0002-GRAPH-SCATTERPLOT-fixed-crash-in-psppire-gui-bug-440.patch added by beckmanf (13KiB - application/octet-stream - patches to fix bug #44012, formatting and x vs. y title)
file #33752:  0003-scatterplot-changed-chart-title-from-x-vs.-y-to-y-vs.patch added by beckmanf (1KiB - application/octet-stream - patches to fix bug #44012, formatting and x vs. y title)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by beckmanf (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-05-25 beckmanf StatusNone Done
        Open/ClosedOpen Closed
    2015-04-24 beckmanf Attached File- Added 0001-added-space-between-function-name-and-left-bracket-t.patch, #33750
        Attached File- Added 0002-GRAPH-SCATTERPLOT-fixed-crash-in-psppire-gui-bug-440.patch, #33751
        Attached File- Added 0003-scatterplot-changed-chart-title-from-x-vs.-y-to-y-vs.patch, #33752

    Back to the top


    Powered by Savane 3.9