patchPSPP - Patches: patch #8546, 0.8.4 debian package build stopped...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8546: 0.8.4 debian package build stopped because of render-test.c security warning

Submitter:  Friedrich Beckmann <beckmanf>
Submitted:  Sun 28 Sep 2014 08:59:59 PM UTC
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Sun 28 Sep 2014 11:48:53 PM UTC, comment #1: 

Thank you!  I applied this patch to master.

Ben Pfaff <blp>
Project Administrator
Sun 28 Sep 2014 08:59:59 PM UTC, original submission:  

The debian build stops because of compilation security error for render-test.c during the build process. The following message is shown:

=============== ERROR LOG ==========
gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -I./gl -I./gl -DINSTALLDIR=\"/usr/bin\" -I./src -I./lib -I./src/language/stats -I./src/lang
uage/expressions -I./src/language/expressions -Isrc -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/pango-1.0   -Wall -W -Wwrite-strings -Wstrict-prototypes -Wpointer-arith -Wno-sign-compare -Wmissing-prototypes -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wdeclaration-after-statement -c -o tests/output/render-test.o tests/output/render-test.c
tests/output/render-test.c: In function ‘read_table’:
tests/output/render-test.c:491:19: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: some warnings being treated as errors
make[5]: *** [tests/output/render-test.o] Fehler 1
=============== ERROR LOG ================

The warning is given, because the function tab_footnote results in printf. But in the test scenario the format string is not a literal and no additional arguments are given.

The attached patch avoids the security warning during compilation. 

Friedrich Beckmann <beckmanf>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32194:  render-test.patch added by beckmanf (537B - application/octet-stream - patch for tests/output/render-test.c)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by beckmanf (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-09-28 blp StatusNone Done
        Open/ClosedOpen Closed
    2014-09-28 beckmanf Attached File- Added render-test.patch, #32194

    Back to the top


    Powered by Savane 3.9