patchGnash - The GNU Flash player - Patches: patch #8129, Fix for bug 35545

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8129: Fix for bug 35545

Submitter:  Karl-Felix Glatzer <kfg>
Submitted:  Wed 24 Jul 2013 02:22:19 PM UTC
   
 
Category:  sound Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  bjacques Open/Closed:  Closed

Thu 25 Jul 2013 12:33:58 AM UTC, comment #3: 

I've committed the patch with another small modification in e335377dd7. Thanks!

Bastiaan Jacques <bjacques>
Group Member
Wed 24 Jul 2013 11:11:25 PM UTC, comment #2: 

Done.

(file #28654)

Karl-Felix Glatzer <kfg>
Wed 24 Jul 2013 10:36:59 PM UTC, comment #1: 

I think the patch needs a minor modification, because the other user of sound_hander (embedded sound) uses negative loopCount values to legitimately loop sounds forever. So it would be best, I think, to assign loop a value of std::max(0, loop)  in libcore/asobj/Sound_as.cpp (replacing the current 'sanity check' in sound_start()).

Could you please update your patch with this change?

Bastiaan Jacques <bjacques>
Group Member
Wed 24 Jul 2013 02:22:19 PM UTC, original submission:  

This should fix bug 35545.

As described in the bug report there seems to be no way to create infinite loops using Sound.start.

Karl-Felix Glatzer <kfg>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #28654:  soundStartFix2.patch added by kfg (2KiB - text/x-patch)
file #28651:  soundStartFix.patch added by kfg (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bjacques (Updated the item)
  • -email is unavailable- added by kfg (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-07-25 bjacques StatusNone Done
        Open/ClosedOpen Closed
    2013-07-24 kfg Attached File- Added soundStartFix2.patch, #28654
    2013-07-24 bjacques Assigned toNone bjacques
    2013-07-24 kfg Attached File- Added soundStartFix.patch, #28651

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code