Gnash - The GNU Flash player - Patches: patch #8129, Fix for bug 35545
You are not allowed to post comments on this tracker with your current authentication level.
patch #8129: Fix for bug 35545
Submitter: | Karl-Felix Glatzer <kfg> | ||
Submitted: | Wed 24 Jul 2013 02:22:19 PM UTC | ||
Category: | sound | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | bjacques | Open/Closed: | Closed |
Thu 25 Jul 2013 12:33:58 AM UTC, comment #3: |
Bastiaan Jacques <bjacques> |
Wed 24 Jul 2013 11:11:25 PM UTC, comment #2: Done. |
Karl-Felix Glatzer <kfg> |
Wed 24 Jul 2013 10:36:59 PM UTC, comment #1: I think the patch needs a minor modification, because the other user of sound_hander (embedded sound) uses negative loopCount values to legitimately loop sounds forever. So it would be best, I think, to assign loop a value of std::max(0, loop) in libcore/asobj/Sound_as.cpp (replacing the current 'sanity check' in sound_start()).
|
Bastiaan Jacques <bjacques> |
Wed 24 Jul 2013 02:22:19 PM UTC, original submission:
This should fix bug 35545.
|
Karl-Felix Glatzer <kfg> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2013-07-25 | bjacques | Status | None | Done | |
Open/Closed | Open | Closed | |||
2013-07-24 | kfg | Attached File | - | Added soundStartFix2.patch, #28654 | |
2013-07-24 | bjacques | Assigned to | None | bjacques | |
2013-07-24 | kfg | Attached File | - | Added soundStartFix.patch, #28651 |
Powered by Savane 3.13-4b48.
Corresponding source code
I've committed the patch with another small modification in e335377dd7. Thanks!